Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857073002: Make down-conversion explicit from CFX_Widetring to CFX_WideStringC. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make down-conversion explicit from CFX_Widetring to CFX_WideStringC. Companion to https://codereview.chromium.org/1853233002 BUG= Committed: https://pdfium.googlesource.com/pdfium/+/fc58ad18b7ab32e7b0bb3959b07dbe7538a7cebd

Patch Set 1 #

Patch Set 2 : Comment. #

Total comments: 9

Patch Set 3 : simplify CFX_WideString(L'x').AsWideStringC() => L'x' #

Patch Set 4 : Rebase past dsinclair's c_str() rename. #

Patch Set 5 : String argument type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -300 lines) Patch
M core/fpdfdoc/doc_basic.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 2 3 4 chunks +16 lines, -14 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 5 chunks +7 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M testing/libfuzzer/pdf_fm2js_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 1 2 3 23 chunks +35 lines, -32 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_codabar.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_code128.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_code39.cpp View 2 chunks +10 lines, -7 lines 0 comments Download
M xfa/fxbarcode/cbc_ean13.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_ean8.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_upca.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCodaBarWriter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCode39Writer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 9 chunks +26 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 2 3 1 chunk +8 lines, -11 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 2 3 15 chunks +39 lines, -23 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 2 3 7 chunks +14 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 2 3 28 chunks +48 lines, -32 lines 0 comments Download
M xfa/fxfa/parser/xfa_objectacc_imp.cpp View 1 2 3 10 chunks +18 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 10 chunks +20 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 2 3 10 chunks +17 lines, -14 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 2 3 9 chunks +21 lines, -19 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 2 3 6 chunks +9 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fxfa/xfa_ffwidget.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Tom Sepez
Lei, for review. Trybots on PS#1.
4 years, 8 months ago (2016-04-05 00:04:16 UTC) #2
Lei Zhang
https://codereview.chromium.org/1857073002/diff/20001/xfa/fgas/localization/fgas_locale.cpp File xfa/fgas/localization/fgas_locale.cpp (right): https://codereview.chromium.org/1857073002/diff/20001/xfa/fgas/localization/fgas_locale.cpp#newcode1742 xfa/fgas/localization/fgas_locale.cpp:1742: wsValue = CFX_WideString(str[cc]).AsWideStringC() + wsValue; Just: wsValue = str[cc] ...
4 years, 8 months ago (2016-04-05 00:45:48 UTC) #3
Tom Sepez
PTAAL. https://codereview.chromium.org/1857073002/diff/20001/xfa/fgas/localization/fgas_locale.cpp File xfa/fgas/localization/fgas_locale.cpp (right): https://codereview.chromium.org/1857073002/diff/20001/xfa/fgas/localization/fgas_locale.cpp#newcode1742 xfa/fgas/localization/fgas_locale.cpp:1742: wsValue = CFX_WideString(str[cc]).AsWideStringC() + wsValue; On 2016/04/05 00:45:48, ...
4 years, 8 months ago (2016-04-05 16:34:22 UTC) #4
Tom Sepez
https://codereview.chromium.org/1857073002/diff/20001/xfa/fxfa/app/xfa_ffimageedit.cpp File xfa/fxfa/app/xfa_ffimageedit.cpp (right): https://codereview.chromium.org/1857073002/diff/20001/xfa/fxfa/app/xfa_ffimageedit.cpp#newcode130 xfa/fxfa/app/xfa_ffimageedit.cpp:130: XFA_GetImageType(wsContentType.AsWideStringC()); Anyway, I did this here, but the first ...
4 years, 8 months ago (2016-04-05 18:47:18 UTC) #5
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-05 19:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857073002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857073002/80001
4 years, 8 months ago (2016-04-05 19:21:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 19:22:19 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/fc58ad18b7ab32e7b0bb3959b07dbe7538a7...

Powered by Google App Engine
This is Rietveld 408576698