xfa/fxfa/app/xfa_fffield.cpp - Issue 1857073002: Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_fffield.cpp

Issue 1857073002: Make down-conversion explicit from CFX_Widetring to CFX_WideStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: String argument type Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_fffield.cpp

diff --git a/xfa/fxfa/app/xfa_fffield.cpp b/xfa/fxfa/app/xfa_fffield.cpp

index a0f64e9bb064eb6d40dcce0ffa4ccc6a135b7f3b..229ed437338ed654246306171fa8d4b3abc6f962 100644

--- a/xfa/fxfa/app/xfa_fffield.cpp

+++ b/xfa/fxfa/app/xfa_fffield.cpp

@@ -731,7 +731,8 @@ int32_t CXFA_FFField::CalculateWidgetAcc(CXFA_WidgetAcc* pAcc) {

wsMessage += wsWarning;

CFX_WideString wsTitle;

pAppProvider->LoadString(XFA_IDS_CalcOverride, wsTitle);

- pAppProvider->MsgBox(wsMessage, wsTitle, XFA_MBICON_Warning,

+ pAppProvider->MsgBox(wsMessage.AsWideStringC(),

+ wsTitle.AsWideStringC(), XFA_MBICON_Warning,

XFA_MB_OK);

}

@@ -763,7 +764,8 @@ int32_t CXFA_FFField::CalculateWidgetAcc(CXFA_WidgetAcc* pAcc) {

wsMessage += wsWarning;

CFX_WideString wsTitle;

pAppProvider->LoadString(XFA_IDS_CalcOverride, wsTitle);

- if (pAppProvider->MsgBox(wsMessage, wsTitle, XFA_MBICON_Warning,

+ if (pAppProvider->MsgBox(wsMessage.AsWideStringC(),

+ wsTitle.AsWideStringC(), XFA_MBICON_Warning,

XFA_MB_YesNo) == XFA_IDYes) {

pAcc->GetNode()->SetFlag(XFA_NODEFLAG_UserInteractive, TRUE, FALSE);

return 1;

« no previous file with comments | « xfa/fxfa/app/xfa_ffdocview.cpp ('k') | xfa/fxfa/app/xfa_ffimageedit.cpp » ('j') | no next file with comments »