xfa/fxfa/app/xfa_textlayout.h - Issue 1857073002: Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_textlayout.h

Issue 1857073002: Make down-conversion explicit from CFX_Widetring to CFX_WideStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: String argument type Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_textlayout.h

diff --git a/xfa/fxfa/app/xfa_textlayout.h b/xfa/fxfa/app/xfa_textlayout.h

index 9b92e1796a2ff476b7d7c8671d4ed2793002bbc2..d92a2f40586485e02a345c9fc2b1cf0ada913491 100644

--- a/xfa/fxfa/app/xfa_textlayout.h

+++ b/xfa/fxfa/app/xfa_textlayout.h

@@ -25,7 +25,9 @@ class CXFA_CSSTagProvider : public IFDE_CSSTagProvider {

public:

CXFA_CSSTagProvider() : m_bTagAviliable(FALSE), m_bContent(FALSE) {}

virtual ~CXFA_CSSTagProvider();

- virtual CFX_WideStringC GetTagName() { return m_wsTagName; }

+ // Note: |this| must outlive the use of GetTagName()'s result.

+ virtual CFX_WideStringC GetTagName() { return m_wsTagName.AsWideStringC(); }

virtual FX_POSITION GetFirstAttribute() {

return m_Attributes.GetStartPosition();

}

« no previous file with comments | « xfa/fxfa/app/xfa_fontmgr.cpp ('k') | xfa/fxfa/app/xfa_textlayout.cpp » ('j') | no next file with comments »