Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185653013: [#8] Pass gfx::Point by const ref. (Closed)

Created:
6 years, 9 months ago by prashant.n
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[#8] Pass gfx::Point by const ref. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters and some other scenarios mentioned in the bug. BUG=159273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255025

Patch Set 1 #

Patch Set 2 : Fixed build errors on other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -54 lines) Patch
M cc/base/region.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/region.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/input_handler.h View 5 chunks +8 lines, -8 lines 0 comments Download
M cc/output/filter_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/output/filter_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/shader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/output/shader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/content_layer_updater.h View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/resources/content_layer_updater.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_pile_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
prashant.n
PTAL
6 years, 9 months ago (2014-03-04 09:00:31 UTC) #1
prashant.n
spang@, Please check on Ozone builds.
6 years, 9 months ago (2014-03-04 11:22:00 UTC) #2
danakj
LGTM
6 years, 9 months ago (2014-03-04 15:40:00 UTC) #3
spang
On 2014/03/04 11:22:00, prashant.n wrote: > spang@, Please check on Ozone builds. Tested, thanks. Until ...
6 years, 9 months ago (2014-03-04 15:46:48 UTC) #4
prashant.n
The CQ bit was checked by prashant.n@samsung.com
6 years, 9 months ago (2014-03-04 16:43:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prashant.n@samsung.com/185653013/20001
6 years, 9 months ago (2014-03-04 16:45:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 17:20:38 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53326
6 years, 9 months ago (2014-03-04 17:20:39 UTC) #8
danakj
+jamesr for content/renderer/
6 years, 9 months ago (2014-03-04 17:27:23 UTC) #9
jamesr
content/renderer/ lgtm
6 years, 9 months ago (2014-03-04 21:39:05 UTC) #10
prashant.n
The CQ bit was checked by prashant.n@samsung.com
6 years, 9 months ago (2014-03-05 04:04:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prashant.n@samsung.com/185653013/20001
6 years, 9 months ago (2014-03-05 04:05:21 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 10:35:22 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275125
6 years, 9 months ago (2014-03-05 10:35:23 UTC) #14
prashant.n
The CQ bit was checked by prashant.n@samsung.com
6 years, 9 months ago (2014-03-05 11:48:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prashant.n@samsung.com/185653013/20001
6 years, 9 months ago (2014-03-05 11:48:33 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 12:42:59 UTC) #17
Message was sent while issue was closed. 
Change committed as 255025

Powered by Google App Engine
This is Rietveld 408576698