Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: cc/input/input_handler.h

Issue 185653013: [#8] Pass gfx::Point by const ref. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed build errors on other platforms Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/base/region.cc ('k') | cc/output/filter_operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/input_handler.h
diff --git a/cc/input/input_handler.h b/cc/input/input_handler.h
index e052a4980a4a2e41b0ff07cb5ec0a6e232275f70..fda17cdeee35f6fb8560104a42f2556a94b21b13 100644
--- a/cc/input/input_handler.h
+++ b/cc/input/input_handler.h
@@ -69,7 +69,7 @@ class CC_EXPORT InputHandler {
// can be scrolled, ScrollOnMainThread if the scroll event should instead be
// delegated to the main thread, or ScrollIgnored if there is nothing to be
// scrolled at the given coordinates.
- virtual ScrollStatus ScrollBegin(gfx::Point viewport_point,
+ virtual ScrollStatus ScrollBegin(const gfx::Point& viewport_point,
ScrollInputType type) = 0;
// Scroll the selected layer starting at the given position. If the scroll
@@ -84,12 +84,11 @@ class CC_EXPORT InputHandler {
// the root overscroll accumulated within this ScrollBegin() scope is reported
// to the client.
// Should only be called if ScrollBegin() returned ScrollStarted.
- virtual bool ScrollBy(gfx::Point viewport_point,
+ virtual bool ScrollBy(const gfx::Point& viewport_point,
const gfx::Vector2dF& scroll_delta) = 0;
- virtual bool ScrollVerticallyByPage(
- gfx::Point viewport_point,
- ScrollDirection direction) = 0;
+ virtual bool ScrollVerticallyByPage(const gfx::Point& viewport_point,
+ ScrollDirection direction) = 0;
// Returns ScrollStarted if a layer was being actively being scrolled,
// ScrollIgnored if not.
@@ -97,7 +96,7 @@ class CC_EXPORT InputHandler {
virtual void NotifyCurrentFlingVelocity(const gfx::Vector2dF& velocity) = 0;
- virtual void MouseMoveAt(gfx::Point mouse_position) = 0;
+ virtual void MouseMoveAt(const gfx::Point& mouse_position) = 0;
// Stop scrolling the selected layer. Should only be called if ScrollBegin()
// returned ScrollStarted.
@@ -114,7 +113,8 @@ class CC_EXPORT InputHandler {
virtual void OnRootLayerDelegatedScrollOffsetChanged() = 0;
virtual void PinchGestureBegin() = 0;
- virtual void PinchGestureUpdate(float magnify_delta, gfx::Point anchor) = 0;
+ virtual void PinchGestureUpdate(float magnify_delta,
+ const gfx::Point& anchor) = 0;
virtual void PinchGestureEnd() = 0;
virtual void StartPageScaleAnimation(const gfx::Vector2d& target_offset,
@@ -125,7 +125,7 @@ class CC_EXPORT InputHandler {
// Request another callback to InputHandlerClient::Animate().
virtual void ScheduleAnimation() = 0;
- virtual bool HaveTouchEventHandlersAt(gfx::Point viewport_point) = 0;
+ virtual bool HaveTouchEventHandlersAt(const gfx::Point& viewport_point) = 0;
// Calling CreateLatencyInfoSwapPromiseMonitor() to get a scoped
// LatencyInfoSwapPromiseMonitor. During the life time of the
« no previous file with comments | « cc/base/region.cc ('k') | cc/output/filter_operation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698