Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 185643002: Making the delegate adapter use monotonic only API (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
jamesr, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Second step to remove wallClockTime from Blink's animation delegate interface. We are currently removing trying to remove all references to base::Time (wall clock time) from Chrome/Blink compositor/graphics stack. This requires multiple two-sided patches. Following the process found at https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ukaRczAK6t8/0ludyZ1Nu4cJ The steps are; * Adding monotonic only API to Blink's animation delegate interface https://codereview.chromium.org/185633002 * (This Patch) -- Making the delegate adapter use monotonic only API https://codereview.chromium.org/185643002 * Remove the wallClockTime API from Blink/WebKit. https://codereview.chromium.org/185393005 BUG=299945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255613

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc View 2 chunks +0 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (0 generated)
mithro-old
6 years, 9 months ago (2014-03-03 04:29:12 UTC) #1
ajuma
https://codereview.chromium.org/185643002/diff/1/webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc File webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc (left): https://codereview.chromium.org/185643002/diff/1/webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc#oldcode19 webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc:19: delegate_->notifyAnimationStarted( Suggestion: Do this CL first, using an #ifdef ...
6 years, 9 months ago (2014-03-03 15:26:04 UTC) #2
mithro-old
Adding BLINK_PLATFORM_EXPORT to https://codereview.chromium.org/185633002/ means that Windows compiles fine and we don't need to do ...
6 years, 9 months ago (2014-03-06 01:51:36 UTC) #3
ajuma
lgtm
6 years, 9 months ago (2014-03-06 02:11:37 UTC) #4
jamesr
lgtm
6 years, 9 months ago (2014-03-06 03:43:35 UTC) #5
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-07 00:52:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/185643002/1
6 years, 9 months ago (2014-03-07 01:00:40 UTC) #7
mithro-old
The CQ bit was unchecked by mithro@mithis.com
6 years, 9 months ago (2014-03-07 03:39:52 UTC) #8
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-07 12:02:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/185643002/1
6 years, 9 months ago (2014-03-07 12:03:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 12:09:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 12:09:22 UTC) #12
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-07 12:48:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/185643002/1
6 years, 9 months ago (2014-03-07 12:49:24 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 14:53:55 UTC) #15
Message was sent while issue was closed.
Change committed as 255613

Powered by Google App Engine
This is Rietveld 408576698