Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 185393005: Remove unused wallClockTime API from Blink (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Final step to remove wallClockTime API from animation delegate interface. We are currently removing trying to remove all references to base::Time (wall clock time) from Chrome/Blink compositor/graphics stack. This requires multiple two-sided patches. Following the process found at https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ukaRczAK6t8/0ludyZ1Nu4cJ The steps are; * Adding monotonic only API to Blink's animation delegate interface https://codereview.chromium.org/185633002 * Making the delegate adapter use monotonic only API https://codereview.chromium.org/185643002 * (This Patch) -- Remove the wallClockTime API from Blink/WebKit. https://codereview.chromium.org/185393005 BUG=299945 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168889

Patch Set 1 #

Patch Set 2 : Rebasing. #

Patch Set 3 : Also reverting the BLINK_PLATFORM_EXPORT bit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M public/platform/WebAnimationDelegate.h View 1 2 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mithro-old
6 years, 9 months ago (2014-03-03 04:28:46 UTC) #1
mithro-old
Friendly poke, this CL isn't urgent. This CL will need to wait for https://codereview.chromium.org/184433007/ to ...
6 years, 9 months ago (2014-03-10 01:34:39 UTC) #2
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-10 21:20:55 UTC) #3
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-11 05:07:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/185393005/70001
6 years, 9 months ago (2014-03-11 05:07:29 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 07:00:59 UTC) #6
Message was sent while issue was closed.
Change committed as 168889

Powered by Google App Engine
This is Rietveld 408576698