Simplify layout attribute invalidation in LayoutSVGText

Simplify layout attribute invalidation in LayoutSVGText

Move invalidation to a new method (invalidatePositioningValues), and
also make sure to clear LayoutSVGText::m_layoutAttributes to make it
more robust.

BUG=405966, 594058
Committed: https://crrev.com/b257f2cbf0437ce542434870b460970fdc20fb77
Cr-Commit-Position: refs/heads/master@{#385274}

[fs, 2016-04-05 14:51:03]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-04-05 18:12:36]

LGTM with a few comments. All of these can be done in followups if you'd prefer.

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp (right):

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:125: if
(!shouldHandleSubtreeMutations() || documentBeingDestroyed())
(Minor cleanup for some other patch) shouldHandleSubtreeMutations is actually
just "beingDestroyed() || !everHadLayout()". I think it would make more sense to
just write those conditions, or rename the function and move
documentBeingDestroyed into shouldHandleSubtreeMutations.

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:141: void
LayoutSVGText::subtreeChildWillBeRemoved(LayoutObject*)
Similar here, can you remove the argument entirely?

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:151: void
LayoutSVGText::subtreeTextDidChange(LayoutSVGInlineText*)
LayoutSVGInlineText::setTextInternal is the only callsite for this. Can you
remove this argument entirely?

[fs, 2016-04-05 19:12:17]

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp (right):

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:125: if
(!shouldHandleSubtreeMutations() || documentBeingDestroyed())
On 2016/04/05 at 18:12:36, pdr wrote:
> (Minor cleanup for some other patch) shouldHandleSubtreeMutations is actually
just "beingDestroyed() || !everHadLayout()". I think it would make more sense to
just write those conditions, or rename the function and move
documentBeingDestroyed into shouldHandleSubtreeMutations.

I folded shouldHandleSubtreeMutations() into its two callers. (Kept the asserts
around although I'm not convinced that they are that useful.)

https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:151: void
LayoutSVGText::subtreeTextDidChange(LayoutSVGInlineText*)
On 2016/04/05 at 18:12:36, pdr wrote:
> LayoutSVGInlineText::setTextInternal is the only callsite for this. Can you
remove this argument entirely?

Removed dead argument in all (three) cases.

[fs, 2016-04-05 20:13:09]

The CQ bit was checked by fs@opera.com

[fs, 2016-04-05 20:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1856393002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-04-05 20:13:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1856393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1856393002/20001

[commit-bot: I haz the power, 2016-04-05 20:29:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 20:31:25]

Description was changed from

==========
Simplify layout attribute invalidation in LayoutSVGText

Move invalidation to a new method (invalidatePositioningValues), and
also make sure to clear LayoutSVGText::m_layoutAttributes to make it
more robust.

BUG=405966, 594058
==========

to

==========
Simplify layout attribute invalidation in LayoutSVGText

Move invalidation to a new method (invalidatePositioningValues), and
also make sure to clear LayoutSVGText::m_layoutAttributes to make it
more robust.

BUG=405966, 594058

Committed: https://crrev.com/b257f2cbf0437ce542434870b460970fdc20fb77
Cr-Commit-Position: refs/heads/master@{#385274}
==========

[commit-bot: I haz the power, 2016-04-05 20:31:26]

Patchset 2 (id:??) landed as
https://crrev.com/b257f2cbf0437ce542434870b460970fdc20fb77
Cr-Commit-Position: refs/heads/master@{#385274}