Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify layout attribute invalidation in LayoutSVGText Move invalidation to a new method (invalidatePositioningValues), and also make sure to clear LayoutSVGText::m_layoutAttributes to make it more robust. BUG=405966, 594058 Committed: https://crrev.com/b257f2cbf0437ce542434870b460970fdc20fb77 Cr-Commit-Position: refs/heads/master@{#385274}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 4 chunks +25 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 8 months ago (2016-04-05 14:51:03 UTC) #2
pdr.
LGTM with a few comments. All of these can be done in followups if you'd ...
4 years, 8 months ago (2016-04-05 18:12:36 UTC) #3
fs
https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp (right): https://codereview.chromium.org/1856393002/diff/1/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp#newcode125 third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp:125: if (!shouldHandleSubtreeMutations() || documentBeingDestroyed()) On 2016/04/05 at 18:12:36, pdr ...
4 years, 8 months ago (2016-04-05 19:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856393002/20001
4 years, 8 months ago (2016-04-05 20:13:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 20:29:46 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 20:31:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b257f2cbf0437ce542434870b460970fdc20fb77
Cr-Commit-Position: refs/heads/master@{#385274}

Powered by Google App Engine
This is Rietveld 408576698