third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h - Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

index 043dfab6cce0108fc471d964b8010c4e45ec2e94..c3582a1fc86427b9792de8ee031412bb30cde54a 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

@@ -52,9 +52,9 @@ public:

bool needsReordering() const { return m_needsReordering; }

Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttributes; }

- void subtreeChildWasAdded(LayoutObject*);

- void subtreeChildWillBeRemoved(LayoutObject*);

- void subtreeTextDidChange(LayoutSVGInlineText*);

+ void subtreeChildWasAdded();

+ void subtreeChildWillBeRemoved();

+ void subtreeTextDidChange();

const AffineTransform& localToSVGParentTransform() const override { return m_localTransform; }

@@ -79,7 +79,7 @@ private:

RootInlineBox* createRootInlineBox() override;

- bool shouldHandleSubtreeMutations() const;

+ void invalidatePositioningValues(LayoutInvalidationReasonForTracing);

bool m_needsReordering : 1;

bool m_needsPositioningValuesUpdate : 1;