third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index 4ee1f830fdf92f645ca0e855d7ad9052f9e6453f..a3fafe63669ed8cd369c6e688fd1bf452619ab10 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -69,7 +69,7 @@ void LayoutSVGInlineText::setTextInternal(PassRefPtr<StringImpl> text)

{

LayoutText::setTextInternal(text);

if (LayoutSVGText* textLayoutObject = LayoutSVGText::locateLayoutSVGTextAncestor(this))

- textLayoutObject->subtreeTextDidChange(this);

+ textLayoutObject->subtreeTextDidChange();

}

void LayoutSVGInlineText::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)