Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h

Issue 1856393002: Simplify layout attribute invalidation in LayoutSVGText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 FloatRect objectBoundingBox() const override { return FloatRect(frameRect()) ; } 45 FloatRect objectBoundingBox() const override { return FloatRect(frameRect()) ; }
46 FloatRect strokeBoundingBox() const override; 46 FloatRect strokeBoundingBox() const override;
47 bool isObjectBoundingBoxValid() const; 47 bool isObjectBoundingBoxValid() const;
48 48
49 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*); 49 static LayoutSVGText* locateLayoutSVGTextAncestor(LayoutObject*);
50 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ; 50 static const LayoutSVGText* locateLayoutSVGTextAncestor(const LayoutObject*) ;
51 51
52 bool needsReordering() const { return m_needsReordering; } 52 bool needsReordering() const { return m_needsReordering; }
53 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; } 53 Vector<SVGTextLayoutAttributes*>& layoutAttributes() { return m_layoutAttrib utes; }
54 54
55 void subtreeChildWasAdded(LayoutObject*); 55 void subtreeChildWasAdded();
56 void subtreeChildWillBeRemoved(LayoutObject*); 56 void subtreeChildWillBeRemoved();
57 void subtreeTextDidChange(LayoutSVGInlineText*); 57 void subtreeTextDidChange();
58 58
59 const AffineTransform& localToSVGParentTransform() const override { return m _localTransform; } 59 const AffineTransform& localToSVGParentTransform() const override { return m _localTransform; }
60 60
61 const char* name() const override { return "LayoutSVGText"; } 61 const char* name() const override { return "LayoutSVGText"; }
62 62
63 private: 63 private:
64 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGText || LayoutSVGBlock::isOfType(type); } 64 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGText || LayoutSVGBlock::isOfType(type); }
65 65
66 void paint(const PaintInfo&, const LayoutPoint&) const override; 66 void paint(const PaintInfo&, const LayoutPoint&) const override;
67 bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTe stAction) override; 67 bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTe stAction) override;
68 PositionWithAffinity positionForPoint(const LayoutPoint&) override; 68 PositionWithAffinity positionForPoint(const LayoutPoint&) override;
69 69
70 void layout() override; 70 void layout() override;
71 71
72 void absoluteQuads(Vector<FloatQuad>&) const override; 72 void absoluteQuads(Vector<FloatQuad>&) const override;
73 73
74 void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) over ride; 74 void addChild(LayoutObject* child, LayoutObject* beforeChild = nullptr) over ride;
75 void removeChild(LayoutObject*) override; 75 void removeChild(LayoutObject*) override;
76 void willBeDestroyed() override; 76 void willBeDestroyed() override;
77 77
78 void invalidateTreeIfNeeded(const PaintInvalidationState&) override; 78 void invalidateTreeIfNeeded(const PaintInvalidationState&) override;
79 79
80 RootInlineBox* createRootInlineBox() override; 80 RootInlineBox* createRootInlineBox() override;
81 81
82 bool shouldHandleSubtreeMutations() const; 82 void invalidatePositioningValues(LayoutInvalidationReasonForTracing);
83 83
84 bool m_needsReordering : 1; 84 bool m_needsReordering : 1;
85 bool m_needsPositioningValuesUpdate : 1; 85 bool m_needsPositioningValuesUpdate : 1;
86 bool m_needsTransformUpdate : 1; 86 bool m_needsTransformUpdate : 1;
87 bool m_needsTextMetricsUpdate : 1; 87 bool m_needsTextMetricsUpdate : 1;
88 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder; 88 SVGTextLayoutAttributesBuilder m_layoutAttributesBuilder;
89 Vector<SVGTextLayoutAttributes*> m_layoutAttributes; 89 Vector<SVGTextLayoutAttributes*> m_layoutAttributes;
90 }; 90 };
91 91
92 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText()); 92 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGText, isSVGText());
93 93
94 } // namespace blink 94 } // namespace blink
95 95
96 #endif 96 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698