Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 18555002: Split out process killing functions from base/process_util.h into base/process/kill.h. (Closed)

Created:
7 years, 5 months ago by Robert Sesek
Modified:
7 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Split out process killing functions from base/process_util.h into base/process/kill.h. BUG=242290 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+909 lines, -1048 lines) Patch
M base/base.gypi View 3 chunks +6 lines, -1 line 0 comments Download
A base/process/kill.h View 1 chunk +144 lines, -0 lines 0 comments Download
A + base/process/kill.cc View 1 chunk +6 lines, -3 lines 0 comments Download
A + base/process/kill_mac.cc View 1 chunk +3 lines, -58 lines 0 comments Download
A base/process/kill_posix.cc View 1 chunk +493 lines, -0 lines 0 comments Download
A base/process/kill_win.cc View 1 chunk +256 lines, -0 lines 0 comments Download
M base/process_util.h View 3 chunks +1 line, -121 lines 0 comments Download
D base/process_util.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M base/process_util_mac.mm View 1 chunk +0 lines, -155 lines 0 comments Download
M base/process_util_posix.cc View 5 chunks +0 lines, -464 lines 0 comments Download
M base/process_util_win.cc View 4 chunks +0 lines, -223 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
7 years, 5 months ago (2013-07-02 18:17:59 UTC) #1
brettw
sweet. lgtm
7 years, 5 months ago (2013-07-10 18:12:40 UTC) #2
Robert Sesek
7 years, 5 months ago (2013-07-10 18:36:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r210893.

Powered by Google App Engine
This is Rietveld 408576698