Implement receiving side of web notification inline replies

Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2]

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes, NotificationDatabaseDataTest.SerializeAndDeserializeData, NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder,  NotificationDataConversionsTest.ToPlatformNotificationData, NotificationDataConversionsTest.ToWebNotificationData, http/tests/notifications/serviceworker-notification-properties.html, http/tests/notifications/notification-properties.html

Committed: https://crrev.com/d1c3e840df52f94b23a129c5466cb7866c8261c7
Cr-Commit-Position: refs/heads/master@{#385724}

[Nina, 2016-04-01 14:05:29]

nsatragno@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Nina, 2016-04-01 14:05:29]

Michael, please give this patch a look. Thanks!

[Michael van Ouwerkerk, 2016-04-05 09:35:39]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 09:35:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855443002/1

[Michael van Ouwerkerk, 2016-04-05 10:06:55]

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
File content/child/notifications/notification_data_conversions.cc (right):

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:22: static const
char kButtonString[] = "button";
nit: rename to kTypeButton and kTypeText

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:69:
base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
Hmm, it seems no conversions are needed for placeholder and title, can we remove
it here also?

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:123:
blink::WebString::fromUTF8(platform_data.actions[i].action);
Same thing here, can the conversion code be removed?

https://codereview.chromium.org/1855443002/diff/1/content/common/platform_not...
File content/common/platform_notification_messages.h (right):

https://codereview.chromium.org/1855443002/diff/1/content/common/platform_not...
content/common/platform_notification_messages.h:43:
IPC_STRUCT_TRAITS_MEMBER(type)
Please keep the same order of members throughout: in idl, web, content, ipc,
etc.

https://codereview.chromium.org/1855443002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/notifications/NotificationAction.idl
(right):

https://codereview.chromium.org/1855443002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/notifications/NotificationAction.idl:17:
[RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder;
How is null expressed in our implementation, what is the meaning of it? I would
expect that we show some kind of default placeholder string in that case,
instead of the empty string. It looks like we convert it to an empty string,
losing the distinction. It might as well not be nullable then, and have a
default value of "". And if it is nullable, can we assign a default value of
null here?

[commit-bot: I haz the power, 2016-04-05 11:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 11:04:49]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[Nina, 2016-04-05 13:28:22]

Also (hopefully) fixed the failing tests :)

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
File content/child/notifications/notification_data_conversions.cc (right):

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:22: static const
char kButtonString[] = "button";
On 2016/04/05 10:06:54, Michael van Ouwerkerk wrote:
> nit: rename to kTypeButton and kTypeText

Done.

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:69:
base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
On 2016/04/05 10:06:54, Michael van Ouwerkerk wrote:
> Hmm, it seems no conversions are needed for placeholder and title, can we
remove
> it here also?

Unfortunately, action is std::string (as opposed to base::string16).

https://codereview.chromium.org/1855443002/diff/1/content/child/notifications...
content/child/notifications/notification_data_conversions.cc:123:
blink::WebString::fromUTF8(platform_data.actions[i].action);
On 2016/04/05 10:06:54, Michael van Ouwerkerk wrote:
> Same thing here, can the conversion code be removed?

^^

https://codereview.chromium.org/1855443002/diff/1/content/common/platform_not...
File content/common/platform_notification_messages.h (right):

https://codereview.chromium.org/1855443002/diff/1/content/common/platform_not...
content/common/platform_notification_messages.h:43:
IPC_STRUCT_TRAITS_MEMBER(type)
On 2016/04/05 10:06:55, Michael van Ouwerkerk wrote:
> Please keep the same order of members throughout: in idl, web, content, ipc,
> etc.

I think I re-ordered everything in this order:
type
[existing attributes]
placeholder

https://codereview.chromium.org/1855443002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/notifications/NotificationAction.idl
(right):

https://codereview.chromium.org/1855443002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/notifications/NotificationAction.idl:17:
[RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder;
On 2016/04/05 10:06:55, Michael van Ouwerkerk wrote:
> How is null expressed in our implementation, 

I modified the existing code to account for it.

> what is the meaning of it? I would
> expect that we show some kind of default placeholder string in that case,
> instead of the empty string. 

Agreed, this will be reflected in the follow-up patch.

> It looks like we convert it to an empty string,
> losing the distinction. It might as well not be nullable then, and have a
> default value of "". 

Keeping it nullable means we can distinguish between the case where the dev does
not want to specify a placeholder and when they want to specify a blank one.

> And if it is nullable, can we assign a default value of
> null here?

Done!

[Nina, 2016-04-05 13:29:37]

Description was changed from

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent. For a more detailed explanation of the implementation plan and
what the feature does please refer to https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData
==========

to

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent. For a more detailed explanation of the implementation plan and
what the feature does please refer to https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

[Nina, 2016-04-05 13:30:25]

Description was changed from

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent. For a more detailed explanation of the implementation plan and
what the feature does please refer to https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

to

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent. For a more detailed explanation of the implementation plan and
what the feature does please refer to https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

[Michael van Ouwerkerk, 2016-04-05 13:52:47]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 13:53:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855443002/20001

[Michael van Ouwerkerk, 2016-04-05 13:59:50]

lgtm!

[Nina, 2016-04-05 14:11:32]

Description was changed from

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent. For a more detailed explanation of the implementation plan and
what the feature does please refer to https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

to

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2] 

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

[Nina, 2016-04-05 14:17:53]

nsatragno@chromium.org changed reviewers:
+ avi@chromium.org, jbroman@chromium.org, peter@chromium.org

[Nina, 2016-04-05 14:17:54]

avi: content/common & content/public
peter: third_party/WebKit/Source/modules & third_party/WebKit/public
jbroman: RuntimeEnabledFeatures.in

Thanks!

[Nina, 2016-04-05 14:19:42]

nsatragno@chromium.org changed reviewers:
+ mkwst@chromium.org

[Nina, 2016-04-05 14:19:43]

+mkwst for content/common/platform_notification_messages.h security review :)

[Avi (use Gerrit), 2016-04-05 14:32:33]

lgtm

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
File content/child/notifications/notification_data_conversions.cc (right):

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
content/child/notifications/notification_data_conversions.cc:59: if
(web_data.actions[i].type == kTypeButton) {
Who specified WebNotificationAction to be a string? :(

[Michael van Ouwerkerk, 2016-04-05 14:37:49]

`

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
File content/child/notifications/notification_data_conversions.cc (right):

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
content/child/notifications/notification_data_conversions.cc:59: if
(web_data.actions[i].type == kTypeButton) {
On 2016/04/05 14:32:33, Avi wrote:
> Who specified WebNotificationAction to be a string? :(

Avi, the WebNotificationAction is a struct. Are you worried about one of its
members? The action attribute is effectively an id, and it seems reasonable for
that to be a string, no?

[Mike West, 2016-04-05 14:41:00]

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html:57:
type: i % 2 == 0 ? 'button' : 'text',
Can you add some tests for invalid values?

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h:15:
WebString type;
From `NotificationAction.idl`, it looks like this is an enum of `button` or
`text`. Why store/IPC it as a String?

[jbroman, 2016-04-05 15:12:48]

platform lgtm

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/notifications/NotificationAction.idl
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/notifications/NotificationAction.idl:7:
[RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {
FYI, making an enum RuntimeEnabled is a no-op as far as I can tell.

Most .idl files do not mark enums as RuntimeEnabled. (I've filed bug 600726 to
ask the bindings team whether doing this should be an error.)

[Nina, 2016-04-05 16:10:01]

Mike, please see the updated code, I replaced the WebString with a proper enum
on WebNotificationAction. Thanks!

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
File content/child/notifications/notification_data_conversions.cc (right):

https://codereview.chromium.org/1855443002/diff/20001/content/child/notificat...
content/child/notifications/notification_data_conversions.cc:59: if
(web_data.actions[i].type == kTypeButton) {
On 2016/04/05 14:32:33, Avi wrote:
> Who specified WebNotificationAction to be a string? :(

If you meant the type member, I fixed it to be an enum in the next patch set :)

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html:57:
type: i % 2 == 0 ? 'button' : 'text',
On 2016/04/05 14:41:00, Mike West (OOO through 31st) wrote:
> Can you add some tests for invalid values?

This is taken care of automatically by the IDL generator. Added a test on
notification-properties.html.

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/notifications/NotificationAction.idl
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/notifications/NotificationAction.idl:7:
[RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {
On 2016/04/05 15:12:48, jbroman wrote:
> FYI, making an enum RuntimeEnabled is a no-op as far as I can tell.
> 
> Most .idl files do not mark enums as RuntimeEnabled. (I've filed bug 600726 to
> ask the bindings team whether doing this should be an error.)

Ah! I'll leave it like this for now and follow the bug.

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h
(right):

https://codereview.chromium.org/1855443002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h:15:
WebString type;
On 2016/04/05 14:41:00, Mike West (OOO through 31st) wrote:
> From `NotificationAction.idl`, it looks like this is an enum of `button` or
> `text`. Why store/IPC it as a String?

It's being stored and sent through IPC as an enum (see
PlatformNotificationData). However, this here should also be an enum. Updated
the code.

[Mike West, 2016-04-05 16:12:16]

IPC LGTM, thanks.

[Peter Beverloo, 2016-04-06 17:22:00]

lgtm

https://codereview.chromium.org/1855443002/diff/80001/content/browser/notific...
File content/browser/notifications/notification_database_data_conversions.cc
(right):

https://codereview.chromium.org/1855443002/diff/80001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.cc:95:
action.placeholder = base::NullableString16();
nit: this should be done implicitly by the constructor on line 75?

https://codereview.chromium.org/1855443002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/notifications/NotificationData.cpp
(right):

https://codereview.chromium.org/1855443002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/notifications/NotificationData.cpp:104:
exceptionState.throwTypeError("Notifications of type \"button\" cannot specify a
placeholder.");
test?

See NotificationDataTest.cpp

[Nina, 2016-04-07 10:59:09]

https://codereview.chromium.org/1855443002/diff/80001/content/browser/notific...
File content/browser/notifications/notification_database_data_conversions.cc
(right):

https://codereview.chromium.org/1855443002/diff/80001/content/browser/notific...
content/browser/notifications/notification_database_data_conversions.cc:95:
action.placeholder = base::NullableString16();
On 2016/04/06 17:22:00, Peter Beverloo wrote:
> nit: this should be done implicitly by the constructor on line 75?

Indeed! Removed.

https://codereview.chromium.org/1855443002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/notifications/NotificationData.cpp
(right):

https://codereview.chromium.org/1855443002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/notifications/NotificationData.cpp:104:
exceptionState.throwTypeError("Notifications of type \"button\" cannot specify a
placeholder.");
On 2016/04/06 17:22:00, Peter Beverloo wrote:
> test?
> 
> See NotificationDataTest.cpp

Ah, this was only tested on the layout test. Added cpp unittest.

[Nina, 2016-04-07 10:59:18]

The CQ bit was checked by nsatragno@chromium.org

[Nina, 2016-04-07 10:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
jbroman@chromium.org, mvanouwerkerk@chromium.org, mkwst@chromium.org,
peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1855443002/#ps100001
(title: "Added test and removed unnecessary code.")

[commit-bot: I haz the power, 2016-04-07 10:59:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855443002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855443002/100001

[commit-bot: I haz the power, 2016-04-07 12:32:30]

Description was changed from

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2] 

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

to

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2] 

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

[commit-bot: I haz the power, 2016-04-07 12:32:31]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-07 12:34:28]

Description was changed from

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2] 

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html
==========

to

==========
Implement receiving side of web notification inline replies

Implement the part of the web notification inline replies API that tells
actions that they should show a text input. The new API is under an
experimetal flag (NotificationInlineReplies) and does not do anything
yet.

This is a highly experimental API. An intent to implement has already
been sent [1]. For a more detailed explanation of the implementation plan and
what the feature does please refer to the doc [2]

[1] https://goo.gl/7wzBMB
[2] https://goo.gl/qc6g1z

BUG=599859
TEST=NotificationDatabaseDataTest.SerializeAndDeserializeActionTypes,
NotificationDatabaseDataTest.SerializeAndDeserializeData,
NotificationDatabaseDataTest.SerializeAndDeserializeNullPlaceholder, 
NotificationDataConversionsTest.ToPlatformNotificationData,
NotificationDataConversionsTest.ToWebNotificationData,
http/tests/notifications/serviceworker-notification-properties.html,
http/tests/notifications/notification-properties.html

Committed: https://crrev.com/d1c3e840df52f94b23a129c5466cb7866c8261c7
Cr-Commit-Position: refs/heads/master@{#385724}
==========

[commit-bot: I haz the power, 2016-04-07 12:34:29]

Patchset 6 (id:??) landed as
https://crrev.com/d1c3e840df52f94b23a129c5466cb7866c8261c7
Cr-Commit-Position: refs/heads/master@{#385724}