third_party/WebKit/Source/modules/notifications/NotificationAction.idl - Issue 1855443002: Implement receiving side of web notification inline replies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments & Tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html ('K') | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://notifications.spec.whatwg.org/#dictdef-notificationaction	5 // https://notifications.spec.whatwg.org/#dictdef-notificationaction

6	6

	7 [RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {
	jbroman 2016/04/05 15:12:48 FYI, making an enum RuntimeEnabled is a no-op as f FYI, making an enum RuntimeEnabled is a no-op as far as I can tell. Most .idl files do not mark enums as RuntimeEnabled. (I've filed bug 600726 to ask the bindings team whether doing this should be an error.) Nina 2016/04/05 16:10:01 Ah! I'll leave it like this for now and follow the Show quoted text On 2016/04/05 15:12:48, jbroman wrote: > FYI, making an enum RuntimeEnabled is a no-op as far as I can tell. > > Most .idl files do not mark enums as RuntimeEnabled. (I've filed bug 600726 to > ask the bindings team whether doing this should be an error.) Ah! I'll leave it like this for now and follow the bug.
	8 "button",

	9 "text"

	10 };

	11

7 dictionary NotificationAction {	12 dictionary NotificationAction {

	13 [RuntimeEnabled=NotificationInlineReplies] NotificationActionType type = "bu tton";

8 required DOMString action;	14 required DOMString action;

9 required DOMString title;	15 required DOMString title;

10 [RuntimeEnabled=NotificationActionIcons] USVString icon;	16 [RuntimeEnabled=NotificationActionIcons] USVString icon;

	17 [RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder = null;

11 };	18 };

OLD	NEW