third_party/WebKit/Source/modules/notifications/NotificationAction.idl - Issue 1855443002: Implement receiving side of web notification inline replies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/platform_notification_messages.h ('K') | « content/public/common/platform_notification_data.h ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://notifications.spec.whatwg.org/#dictdef-notificationaction	5 // https://notifications.spec.whatwg.org/#dictdef-notificationaction

6	6

	7 [RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {

	8 "button",

	9 "text"

	10 };

	11

7 dictionary NotificationAction {	12 dictionary NotificationAction {

8 required DOMString action;	13 required DOMString action;

9 required DOMString title;	14 required DOMString title;

10 [RuntimeEnabled=NotificationActionIcons] USVString icon;	15 [RuntimeEnabled=NotificationActionIcons] USVString icon;

	16 [RuntimeEnabled=NotificationInlineReplies] NotificationActionType type = "bu tton";

	17 [RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder;
	Michael van Ouwerkerk 2016/04/05 10:06:55 How is null expressed in our implementation, what How is null expressed in our implementation, what is the meaning of it? I would expect that we show some kind of default placeholder string in that case, instead of the empty string. It looks like we convert it to an empty string, losing the distinction. It might as well not be nullable then, and have a default value of "". And if it is nullable, can we assign a default value of null here? Nina 2016/04/05 13:28:22 I modified the existing code to account for it. Show quoted text On 2016/04/05 10:06:55, Michael van Ouwerkerk wrote: > How is null expressed in our implementation, I modified the existing code to account for it. Show quoted text > what is the meaning of it? I would > expect that we show some kind of default placeholder string in that case, > instead of the empty string. Agreed, this will be reflected in the follow-up patch. Show quoted text > It looks like we convert it to an empty string, > losing the distinction. It might as well not be nullable then, and have a > default value of "". Keeping it nullable means we can distinguish between the case where the dev does not want to specify a placeholder and when they want to specify a blank one. Show quoted text > And if it is nullable, can we assign a default value of > null here? Done!
11 };	18 };

OLD	NEW