third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h - Issue 1855443002: Implement receiving side of web notification inline replies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments & Tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebNotificationAction_h	5 #ifndef WebNotificationAction_h

6 #define WebNotificationAction_h	6 #define WebNotificationAction_h

7	7

8 #include "public/platform/WebString.h"	8 #include "public/platform/WebString.h"

9 #include "public/platform/WebURL.h"	9 #include "public/platform/WebURL.h"

10	10

11 namespace blink {	11 namespace blink {

12	12

13 // Structure representing the data associated with a Web Notification action.	13 // Structure representing the data associated with a Web Notification action.

14 struct WebNotificationAction {	14 struct WebNotificationAction {

	15 WebString type;
	Mike West 2016/04/05 14:41:00 From `NotificationAction.idl`, it looks like this From `NotificationAction.idl`, it looks like this is an enum of `button` or `text`. Why store/IPC it as a String? Nina 2016/04/05 16:10:01 It's being stored and sent through IPC as an enum Show quoted text On 2016/04/05 14:41:00, Mike West (OOO through 31st) wrote: > From `NotificationAction.idl`, it looks like this is an enum of `button` or > `text`. Why store/IPC it as a String? It's being stored and sent through IPC as an enum (see PlatformNotificationData). However, this here should also be an enum. Updated the code.
15 WebString action;	16 WebString action;

16 WebString title;	17 WebString title;

17 WebURL icon;	18 WebURL icon;

	19 WebString placeholder;

18 };	20 };

19	21

20 } // namespace blink	22 } // namespace blink

21	23

22 #endif // WebNotificationAction_h	24 #endif // WebNotificationAction_h

OLD	NEW