Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 1854423003: Bugfix: assert in lithium compile for LMaybeGrowElements (Closed)

Created:
4 years, 8 months ago by mvstanton
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bugfix: assert in lithium compile for LMaybeGrowElements BUG=chromium:585041 LOG=N Committed: https://crrev.com/ce1fe78d7e7d8b45d56bcab4cea1d3eab6dcfc79 Cr-Commit-Position: refs/heads/master@{#35331}

Patch Set 1 #

Patch Set 2 : Better fix. #

Patch Set 3 : Removed unnecessary arm code. #

Patch Set 4 : Fixed test bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -12 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-585041.js View 1 2 3 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mvstanton
Hi Jaro, here is the fix we discussed, thx for the help! --Mike
4 years, 8 months ago (2016-04-06 11:05:30 UTC) #2
Jarin
lgtm. Thanks!
4 years, 8 months ago (2016-04-07 11:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854423003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854423003/60001
4 years, 8 months ago (2016-04-07 11:13:56 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-07 11:41:17 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 11:41:50 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ce1fe78d7e7d8b45d56bcab4cea1d3eab6dcfc79
Cr-Commit-Position: refs/heads/master@{#35331}

Powered by Google App Engine
This is Rietveld 408576698