Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 1854423003: Bugfix: assert in lithium compile for LMaybeGrowElements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed test bug. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 3956 matching lines...) Expand 10 before | Expand all | Expand 10 after
3967 { 3967 {
3968 PushSafepointRegistersScope scope(this); 3968 PushSafepointRegistersScope scope(this);
3969 if (instr->object()->IsRegister()) { 3969 if (instr->object()->IsRegister()) {
3970 __ Move(result, ToRegister(instr->object())); 3970 __ Move(result, ToRegister(instr->object()));
3971 } else { 3971 } else {
3972 __ mov(result, ToOperand(instr->object())); 3972 __ mov(result, ToOperand(instr->object()));
3973 } 3973 }
3974 3974
3975 LOperand* key = instr->key(); 3975 LOperand* key = instr->key();
3976 if (key->IsConstantOperand()) { 3976 if (key->IsConstantOperand()) {
3977 __ mov(ebx, ToImmediate(key, Representation::Smi())); 3977 LConstantOperand* constant_key = LConstantOperand::cast(key);
3978 int32_t int_key = ToInteger32(constant_key);
3979 if (Smi::IsValid(int_key)) {
3980 __ mov(ebx, Immediate(Smi::FromInt(int_key)));
3981 } else {
3982 // We should never get here at runtime because there is a smi check on
3983 // the key before this point.
3984 __ int3();
3985 }
3978 } else { 3986 } else {
3979 __ Move(ebx, ToRegister(key)); 3987 __ Move(ebx, ToRegister(key));
3980 __ SmiTag(ebx); 3988 __ SmiTag(ebx);
3981 } 3989 }
3982 3990
3983 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(), 3991 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(),
3984 instr->hydrogen()->kind()); 3992 instr->hydrogen()->kind());
3985 __ CallStub(&stub); 3993 __ CallStub(&stub);
3986 RecordSafepointWithLazyDeopt( 3994 RecordSafepointWithLazyDeopt(
3987 instr, RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS); 3995 instr, RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS);
(...skipping 1292 matching lines...) Expand 10 before | Expand all | Expand 10 after
5280 __ bind(deferred->exit()); 5288 __ bind(deferred->exit());
5281 __ bind(&done); 5289 __ bind(&done);
5282 } 5290 }
5283 5291
5284 #undef __ 5292 #undef __
5285 5293
5286 } // namespace internal 5294 } // namespace internal
5287 } // namespace v8 5295 } // namespace v8
5288 5296
5289 #endif // V8_TARGET_ARCH_IA32 5297 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698