Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 1854423003: Bugfix: assert in lithium compile for LMaybeGrowElements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed test bug. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm/lithium-codegen-arm.h" 5 #include "src/crankshaft/arm/lithium-codegen-arm.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h" 10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h"
(...skipping 4174 matching lines...) Expand 10 before | Expand all | Expand 10 after
4185 { 4185 {
4186 PushSafepointRegistersScope scope(this); 4186 PushSafepointRegistersScope scope(this);
4187 if (instr->object()->IsRegister()) { 4187 if (instr->object()->IsRegister()) {
4188 __ Move(result, ToRegister(instr->object())); 4188 __ Move(result, ToRegister(instr->object()));
4189 } else { 4189 } else {
4190 __ ldr(result, ToMemOperand(instr->object())); 4190 __ ldr(result, ToMemOperand(instr->object()));
4191 } 4191 }
4192 4192
4193 LOperand* key = instr->key(); 4193 LOperand* key = instr->key();
4194 if (key->IsConstantOperand()) { 4194 if (key->IsConstantOperand()) {
4195 __ Move(r3, Operand(ToSmi(LConstantOperand::cast(key)))); 4195 LConstantOperand* constant_key = LConstantOperand::cast(key);
4196 int32_t int_key = ToInteger32(constant_key);
4197 if (Smi::IsValid(int_key)) {
4198 __ mov(r3, Operand(Smi::FromInt(int_key)));
4199 } else {
4200 // We should never get here at runtime because there is a smi check on
4201 // the key before this point.
4202 __ stop("expected smi");
4203 }
4196 } else { 4204 } else {
4197 __ Move(r3, ToRegister(key)); 4205 __ Move(r3, ToRegister(key));
4198 __ SmiTag(r3); 4206 __ SmiTag(r3);
4199 } 4207 }
4200 4208
4201 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(), 4209 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(),
4202 instr->hydrogen()->kind()); 4210 instr->hydrogen()->kind());
4203 __ CallStub(&stub); 4211 __ CallStub(&stub);
4204 RecordSafepointWithLazyDeopt( 4212 RecordSafepointWithLazyDeopt(
4205 instr, RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS); 4213 instr, RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS);
(...skipping 1332 matching lines...) Expand 10 before | Expand all | Expand 10 after
5538 __ ldr(result, FieldMemOperand(scratch, 5546 __ ldr(result, FieldMemOperand(scratch,
5539 FixedArray::kHeaderSize - kPointerSize)); 5547 FixedArray::kHeaderSize - kPointerSize));
5540 __ bind(deferred->exit()); 5548 __ bind(deferred->exit());
5541 __ bind(&done); 5549 __ bind(&done);
5542 } 5550 }
5543 5551
5544 #undef __ 5552 #undef __
5545 5553
5546 } // namespace internal 5554 } // namespace internal
5547 } // namespace v8 5555 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698