Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: src/crankshaft/mips64/lithium-codegen-mips64.cc

Issue 1854423003: Bugfix: assert in lithium compile for LMaybeGrowElements (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed test bug. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | test/mjsunit/regress/regress-585041.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h" 5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h"
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h" 10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h"
(...skipping 4372 matching lines...) Expand 10 before | Expand all | Expand 10 after
4383 { 4383 {
4384 PushSafepointRegistersScope scope(this); 4384 PushSafepointRegistersScope scope(this);
4385 if (instr->object()->IsRegister()) { 4385 if (instr->object()->IsRegister()) {
4386 __ mov(result, ToRegister(instr->object())); 4386 __ mov(result, ToRegister(instr->object()));
4387 } else { 4387 } else {
4388 __ ld(result, ToMemOperand(instr->object())); 4388 __ ld(result, ToMemOperand(instr->object()));
4389 } 4389 }
4390 4390
4391 LOperand* key = instr->key(); 4391 LOperand* key = instr->key();
4392 if (key->IsConstantOperand()) { 4392 if (key->IsConstantOperand()) {
4393 __ li(a3, Operand(ToSmi(LConstantOperand::cast(key)))); 4393 LConstantOperand* constant_key = LConstantOperand::cast(key);
4394 int32_t int_key = ToInteger32(constant_key);
4395 if (Smi::IsValid(int_key)) {
4396 __ li(a3, Operand(Smi::FromInt(int_key)));
4397 } else {
4398 // We should never get here at runtime because there is a smi check on
4399 // the key before this point.
4400 __ stop("expected smi");
4401 }
4394 } else { 4402 } else {
4395 __ mov(a3, ToRegister(key)); 4403 __ mov(a3, ToRegister(key));
4396 __ SmiTag(a3); 4404 __ SmiTag(a3);
4397 } 4405 }
4398 4406
4399 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(), 4407 GrowArrayElementsStub stub(isolate(), instr->hydrogen()->is_js_array(),
4400 instr->hydrogen()->kind()); 4408 instr->hydrogen()->kind());
4401 __ mov(a0, result); 4409 __ mov(a0, result);
4402 __ CallStub(&stub); 4410 __ CallStub(&stub);
4403 RecordSafepointWithLazyDeopt( 4411 RecordSafepointWithLazyDeopt(
(...skipping 1352 matching lines...) Expand 10 before | Expand all | Expand 10 after
5756 __ ld(result, FieldMemOperand(scratch, 5764 __ ld(result, FieldMemOperand(scratch,
5757 FixedArray::kHeaderSize - kPointerSize)); 5765 FixedArray::kHeaderSize - kPointerSize));
5758 __ bind(deferred->exit()); 5766 __ bind(deferred->exit());
5759 __ bind(&done); 5767 __ bind(&done);
5760 } 5768 }
5761 5769
5762 #undef __ 5770 #undef __
5763 5771
5764 } // namespace internal 5772 } // namespace internal
5765 } // namespace v8 5773 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | test/mjsunit/regress/regress-585041.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698