First blitter for linear pipeline.

Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852613002

Committed: https://skia.googlesource.com/skia/+/69076fe5cf88c45b8dac4ca44bc5845f8817a57e

[herb_g, 2016-03-31 22:38:09]

Description was changed from

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
==========

to

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-06 15:30:23]

Working repeat tiler, but not efficient.

[herb_g, 2016-04-08 19:51:27]

Address review comments.

[herb_g, 2016-04-08 20:48:33]

sync

[herb_g, 2016-04-08 20:50:25]

Remove junk.

[herb_g, 2016-04-09 20:28:49]

sync

[herb_g, 2016-04-09 20:34:37]

remove test

[herb_g, 2016-04-09 20:35:53]

Description was changed from

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-04-09 20:35:54]

herb@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-04-11 10:23:23]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-04-11 10:23:24]

What is the speed-up w/ this new specialization?

[mtklein, 2016-04-11 16:43:24]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-04-11 16:43:25]

lgtm

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkBitmapProcS...
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkBitmapProcS...
src/core/SkBitmapProcShader.cpp:181: if (mode == SkXfermode::kSrcOver_Mode
This section here is not a constraint on when we can create the linear pipeline,
so it might be clearer to move this way up first in the function.

Moving more of this can-we-create-pipeline logic into the pipeline class would
be nice, e.g.

static bool PlacementNewIfPossible(void*,...);

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkLinearBitma...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkLinearBitma...
src/core/SkLinearBitmapPipeline.cpp:797: }
It is weird that we've constructed an object here where it's sensible to call
blitSpan() but not shadeSpan4f().

[herb_g, 2016-04-12 20:01:11]

Moved check and construction of blitter pipeline to SkLinearBitmapPipeline.

[herb_g, 2016-04-12 20:03:49]

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkBitmapProcS...
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkBitmapProcS...
src/core/SkBitmapProcShader.cpp:181: if (mode == SkXfermode::kSrcOver_Mode
On 2016/04/11 16:43:25, mtklein wrote:
> This section here is not a constraint on when we can create the linear
pipeline,
> so it might be clearer to move this way up first in the function.
> 
> Moving more of this can-we-create-pipeline logic into the pipeline class would
> be nice, e.g.
> 
> static bool PlacementNewIfPossible(void*,...);

Done.

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkLinearBitma...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1852613002/diff/120001/src/core/SkLinearBitma...
src/core/SkLinearBitmapPipeline.cpp:797: }
On 2016/04/11 16:43:25, mtklein wrote:
> It is weird that we've constructed an object here where it's sensible to call
> blitSpan() but not shadeSpan4f().

I think that shadeSpan4f will go away as we restructure higher levels of the
code.

[herb_g, 2016-04-12 20:04:23]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 20:04:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852613002/140001

[commit-bot: I haz the power, 2016-04-12 20:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 20:33:25]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-04-12 21:06:36]

The CQ bit was checked by herb@google.com

[herb_g, 2016-04-12 21:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1852613002/#ps140001
(title: "Moved check and construction of blitter pipeline to
SkLinearBitmapPipeline.")

[commit-bot: I haz the power, 2016-04-12 21:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852613002/140001

[commit-bot: I haz the power, 2016-04-12 21:08:02]

Description was changed from

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Blitter for repeat RGBA8888->RGBA8888.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/69076fe5cf88c45b8dac4ca44bc5845f8817a57e
==========

[commit-bot: I haz the power, 2016-04-12 21:08:03]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/69076fe5cf88c45b8dac4ca44bc5845f8817a57e