Replacing most of web_task.h with base::Closure + base::WeakPtrFactory.

Replacing most of web_task.h with base::Closure + base::WeakPtrFactory.

WebMethodTask was used to wrap and invoke a method pointer.  This can be
replaced by wrapping the method in a base::Closure instead.

When WebTaskList was used as a field of an object, it would make sure
that after the object's destruction, no associated callbacks / WebTasks
would run.  The same functionality can be accomplished via
base::WeakPtrFactory which has the same effect of suppressing
base::Callbacks after the WeakPtrFactory dies.

There were also a few implementations of test_runner::WebTask other
than test_runner::WebMethodTask - these other implementations
could also be simplified by building on top of base::Callback.

BUG=595089
Committed: https://crrev.com/c935882393f5644d8e06c2fbeaeab65f9527ffcb
Cr-Commit-Position: refs/heads/master@{#385752}

[Łukasz Anforowicz, 2016-04-06 23:56:48]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-06 23:56:49]

jochen@, could you please take a look?

https://codereview.chromium.org/1852603002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/css/counters/counter-reparent-table-children-crash.html
(right):

https://codereview.chromium.org/1852603002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/counters/counter-reparent-table-children-crash.html:16:
testRunner.notifyDone();
This turned out to cause a failure after adding one of the extra
TestRunner::weak_factory_.InvalidateWeakPtrs() calls (in places where we used to
have task_list_.RevokeAll()).  Obviously - the test should *first* say what kind
of options it wants and *then* finish.

[jochen (gone - plz use gerrit), 2016-04-07 03:38:18]

lgtm

[Łukasz Anforowicz, 2016-04-07 14:07:40]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-07 14:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852603002/100001

[commit-bot: I haz the power, 2016-04-07 14:43:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-07 14:44:57]

Description was changed from

==========
Replacing most of web_task.h with base::Closure + base::WeakPtrFactory.

WebMethodTask was used to wrap and invoke a method pointer.  This can be
replaced by wrapping the method in a base::Closure instead.

When WebTaskList was used as a field of an object, it would make sure
that after the object's destruction, no associated callbacks / WebTasks
would run.  The same functionality can be accomplished via
base::WeakPtrFactory which has the same effect of suppressing
base::Callbacks after the WeakPtrFactory dies.

There were also a few implementations of test_runner::WebTask other
than test_runner::WebMethodTask - these other implementations
could also be simplified by building on top of base::Callback.

BUG=595089
==========

to

==========
Replacing most of web_task.h with base::Closure + base::WeakPtrFactory.

WebMethodTask was used to wrap and invoke a method pointer.  This can be
replaced by wrapping the method in a base::Closure instead.

When WebTaskList was used as a field of an object, it would make sure
that after the object's destruction, no associated callbacks / WebTasks
would run.  The same functionality can be accomplished via
base::WeakPtrFactory which has the same effect of suppressing
base::Callbacks after the WeakPtrFactory dies.

There were also a few implementations of test_runner::WebTask other
than test_runner::WebMethodTask - these other implementations
could also be simplified by building on top of base::Callback.

BUG=595089

Committed: https://crrev.com/c935882393f5644d8e06c2fbeaeab65f9527ffcb
Cr-Commit-Position: refs/heads/master@{#385752}
==========

[commit-bot: I haz the power, 2016-04-07 14:44:58]

Patchset 6 (id:??) landed as
https://crrev.com/c935882393f5644d8e06c2fbeaeab65f9527ffcb
Cr-Commit-Position: refs/heads/master@{#385752}