Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: components/test_runner/web_view_test_client.h

Issue 1852603002: Replacing most of web_task.h with base::Closure + base::WeakPtrFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-mocks-to-test-runner
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_interfaces.cc ('k') | components/test_runner/web_view_test_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_view_test_client.h
diff --git a/components/test_runner/web_view_test_client.h b/components/test_runner/web_view_test_client.h
index 9e1a09e937023e3648d1d959574b149f58bbb4dc..701354d5a9adc1935f6b5d9db131eaefbd87628a 100644
--- a/components/test_runner/web_view_test_client.h
+++ b/components/test_runner/web_view_test_client.h
@@ -6,7 +6,7 @@
#define COMPONENTS_TEST_RUNNER_WEB_VIEW_TEST_CLIENT_H_
#include "base/macros.h"
-#include "components/test_runner/web_task.h"
+#include "base/memory/weak_ptr.h"
#include "third_party/WebKit/public/web/WebViewClient.h"
namespace blink {
@@ -68,9 +68,6 @@ class WebViewTestClient : public blink::WebViewClient {
void resetInputMethod() override;
blink::WebString acceptLanguages() override;
- // Members expected by WebTask-related templates.
- WebTaskList* mutable_task_list() { return &task_list_; }
-
private:
void AnimateNow();
@@ -82,7 +79,7 @@ class WebViewTestClient : public blink::WebViewClient {
bool animation_scheduled_;
- WebTaskList task_list_;
+ base::WeakPtrFactory<WebViewTestClient> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(WebViewTestClient);
};
« no previous file with comments | « components/test_runner/web_test_interfaces.cc ('k') | components/test_runner/web_view_test_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698