Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: components/test_runner/spell_check_client.h

Issue 1852603002: Replacing most of web_task.h with base::Closure + base::WeakPtrFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-mocks-to-test-runner
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/spell_check_client.h
diff --git a/components/test_runner/spell_check_client.h b/components/test_runner/spell_check_client.h
index 8eac3c1a97eb7043ebc04c7e4f2275b3e82995ac..978c5ba0b0625e64bbc40018cec171b48490ddfd 100644
--- a/components/test_runner/spell_check_client.h
+++ b/components/test_runner/spell_check_client.h
@@ -8,8 +8,8 @@
#include <stdint.h>
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "components/test_runner/mock_spell_check.h"
-#include "components/test_runner/web_task.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/WebKit/public/web/WebSpellCheckClient.h"
@@ -31,8 +31,6 @@ class SpellCheckClient : public blink::WebSpellCheckClient {
void SetDelegate(WebTestDelegate* delegate);
- WebTaskList* mutable_task_list() { return &task_list_; }
-
// blink::WebSpellCheckClient implementation.
void spellCheck(
const blink::WebString& text,
@@ -58,11 +56,11 @@ class SpellCheckClient : public blink::WebSpellCheckClient {
blink::WebString last_requested_text_check_string_;
blink::WebTextCheckingCompletion* last_requested_text_checking_completion_;
- WebTaskList task_list_;
-
TestRunner* test_runner_;
WebTestDelegate* delegate_;
+ base::WeakPtrFactory<SpellCheckClient> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(SpellCheckClient);
};
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | components/test_runner/spell_check_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698