Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: components/test_runner/mock_webrtc_dtmf_sender_handler.h

Issue 1852603002: Replacing most of web_task.h with base::Closure + base::WeakPtrFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-mocks-to-test-runner
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/mock_webrtc_dtmf_sender_handler.h
diff --git a/components/test_runner/mock_webrtc_dtmf_sender_handler.h b/components/test_runner/mock_webrtc_dtmf_sender_handler.h
index 4e6487a91fb061d0e7e24c36aa4d3cb694403b68..20b2b039e8feb14a4e2ea5b3b74ad5fd29c6713a 100644
--- a/components/test_runner/mock_webrtc_dtmf_sender_handler.h
+++ b/components/test_runner/mock_webrtc_dtmf_sender_handler.h
@@ -6,7 +6,7 @@
#define COMPONENTS_TEST_RUNNER_MOCK_WEBRTC_DTMF_SENDER_HANDLER_H_
#include "base/macros.h"
-#include "components/test_runner/web_task.h"
+#include "base/memory/weak_ptr.h"
#include "third_party/WebKit/public/platform/WebMediaStreamTrack.h"
#include "third_party/WebKit/public/platform/WebRTCDTMFSenderHandler.h"
#include "third_party/WebKit/public/platform/WebString.h"
@@ -19,6 +19,7 @@ class MockWebRTCDTMFSenderHandler : public blink::WebRTCDTMFSenderHandler {
public:
MockWebRTCDTMFSenderHandler(const blink::WebMediaStreamTrack& track,
WebTestDelegate* delegate);
+ ~MockWebRTCDTMFSenderHandler() override;
// WebRTCDTMFSenderHandler related methods
void setClient(blink::WebRTCDTMFSenderHandlerClient* client) override;
@@ -28,20 +29,18 @@ class MockWebRTCDTMFSenderHandler : public blink::WebRTCDTMFSenderHandler {
long duration,
long inter_tone_gap) override;
- // WebTask related methods
- WebTaskList* mutable_task_list() { return &task_list_; }
-
void ClearToneBuffer() { tone_buffer_.reset(); }
private:
- MockWebRTCDTMFSenderHandler();
+ void PlayTone();
blink::WebRTCDTMFSenderHandlerClient* client_;
blink::WebMediaStreamTrack track_;
blink::WebString tone_buffer_;
- WebTaskList task_list_;
WebTestDelegate* delegate_;
+ base::WeakPtrFactory<MockWebRTCDTMFSenderHandler> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MockWebRTCDTMFSenderHandler);
};
« no previous file with comments | « components/test_runner/mock_webrtc_data_channel_handler.cc ('k') | components/test_runner/mock_webrtc_dtmf_sender_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698