Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1852513003: Convert //android_webview to use std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
boliu
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //android_webview to use std::unique_ptr BUG=554298 Committed: https://crrev.com/08daa0770adc348a5e3852200352b2cd7f620d21 Cr-Commit-Position: refs/heads/master@{#384471}

Patch Set 1 #

Patch Set 2 : base:::::: #

Total comments: 8

Patch Set 3 : address comments #

Patch Set 4 : git is hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -435 lines) Patch
M android_webview/browser/aw_browser_context.h View 4 chunks +14 lines, -14 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_policy_connector.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 3 chunks +5 lines, -4 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M android_webview/browser/aw_contents_client_bridge_base.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/browser/aw_contents_io_thread_client.h View 3 chunks +6 lines, -5 lines 0 comments Download
M android_webview/browser/aw_cookie_access_policy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_dev_tools_discovery_provider.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/aw_form_database_service.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/aw_form_database_service_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M android_webview/browser/aw_login_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/browser/aw_metrics_service_client.h View 3 chunks +5 lines, -6 lines 0 comments Download
M android_webview/browser/aw_metrics_service_client.cc View 3 chunks +15 lines, -14 lines 0 comments Download
M android_webview/browser/aw_permission_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/browser/aw_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_pref_store.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/aw_render_thread_context_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/browser/browser_view_renderer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M android_webview/browser/child_frame.h View 3 chunks +4 lines, -3 lines 0 comments Download
M android_webview/browser/child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/deferred_gpu_command_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/hardware_renderer.h View 2 chunks +7 lines, -6 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.h View 5 chunks +16 lines, -17 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 1 9 chunks +21 lines, -17 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 1 14 chunks +27 lines, -25 lines 0 comments Download
M android_webview/browser/net/aw_cookie_store_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_cookie_store_wrapper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/net/aw_cookie_store_wrapper_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_request_interceptor.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/net/aw_request_interceptor.cc View 1 6 chunks +13 lines, -12 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 4 chunks +10 lines, -9 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 9 chunks +22 lines, -17 lines 0 comments Download
M android_webview/browser/net/aw_url_request_job_factory.h View 3 chunks +4 lines, -3 lines 0 comments Download
M android_webview/browser/net/aw_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/aw_web_resource_response.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/init_native_callback.h View 2 chunks +6 lines, -5 lines 0 comments Download
M android_webview/browser/net/input_stream_reader_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M android_webview/browser/net/token_binding_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M android_webview/browser/scoped_app_gl_state_restore.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 3 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/browser/test/fake_window.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/test/rendering_test.h View 2 chunks +8 lines, -7 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M android_webview/lib/aw_browser_dependency_factory_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/native/android_protocol_handler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M android_webview/native/android_protocol_handler.cc View 1 6 chunks +14 lines, -13 lines 0 comments Download
M android_webview/native/aw_autofill_client.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.h View 5 chunks +14 lines, -12 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 9 chunks +16 lines, -13 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 1 5 chunks +7 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 7 chunks +17 lines, -15 lines 0 comments Download
M android_webview/native/aw_debug.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_dev_tools_server.h View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_picture.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_picture.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M android_webview/native/aw_settings.h View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M android_webview/native/input_stream_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/native/net_init_native_callback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/permission/aw_permission_request.h View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/native/permission/aw_permission_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/permission/media_access_permission_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/media_access_permission_request_unittest.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M android_webview/native/permission/permission_request_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/permission/permission_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M android_webview/native/state_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/state_serializer_unittest.cc View 8 chunks +15 lines, -11 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M android_webview/renderer/aw_message_port_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
It begins…
4 years, 8 months ago (2016-03-31 23:53:17 UTC) #2
boliu
lgtm found some existing incorrect includes. this CL doesn't make those any worse And idea, ...
4 years, 8 months ago (2016-04-01 00:49:42 UTC) #3
dcheng
https://codereview.chromium.org/1852513003/diff/20001/android_webview/browser/net/input_stream_reader_unittest.cc File android_webview/browser/net/input_stream_reader_unittest.cc (right): https://codereview.chromium.org/1852513003/diff/20001/android_webview/browser/net/input_stream_reader_unittest.cc#newcode7 android_webview/browser/net/input_stream_reader_unittest.cc:7: #include <memory> On 2016/04/01 at 00:49:42, boliu wrote: > ...
4 years, 8 months ago (2016-04-01 00:58:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852513003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852513003/50001
4 years, 8 months ago (2016-04-01 01:00:56 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 8 months ago (2016-04-01 01:47:30 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 01:48:35 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/08daa0770adc348a5e3852200352b2cd7f620d21
Cr-Commit-Position: refs/heads/master@{#384471}

Powered by Google App Engine
This is Rietveld 408576698