Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 1852513003: Convert //android_webview to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git is hard Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/aw_metrics_service_client.h" 5 #include "android_webview/browser/aw_metrics_service_client.h"
6 6
7 #include "android_webview/common/aw_version_info_values.h" 7 #include "android_webview/common/aw_version_info_values.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/guid.h" 10 #include "base/guid.h"
(...skipping 16 matching lines...) Expand all
27 27
28 namespace { 28 namespace {
29 29
30 const int kUploadIntervalMinutes = 30; 30 const int kUploadIntervalMinutes = 30;
31 31
32 // Callbacks for metrics::MetricsStateManager::Create. Store/LoadClientInfo 32 // Callbacks for metrics::MetricsStateManager::Create. Store/LoadClientInfo
33 // allow Windows Chrome to back up ClientInfo. They're no-ops for WebView. 33 // allow Windows Chrome to back up ClientInfo. They're no-ops for WebView.
34 34
35 void StoreClientInfo(const metrics::ClientInfo& client_info) {} 35 void StoreClientInfo(const metrics::ClientInfo& client_info) {}
36 36
37 scoped_ptr<metrics::ClientInfo> LoadClientInfo() { 37 std::unique_ptr<metrics::ClientInfo> LoadClientInfo() {
38 scoped_ptr<metrics::ClientInfo> client_info; 38 std::unique_ptr<metrics::ClientInfo> client_info;
39 return client_info; 39 return client_info;
40 } 40 }
41 41
42 // A GUID in text form is composed of 32 hex digits and 4 hyphens. 42 // A GUID in text form is composed of 32 hex digits and 4 hyphens.
43 const size_t GUID_SIZE = 32 + 4; 43 const size_t GUID_SIZE = 32 + 4;
44 44
45 void GetOrCreateGUID(const base::FilePath guid_file_path, std::string* guid) { 45 void GetOrCreateGUID(const base::FilePath guid_file_path, std::string* guid) {
46 DCHECK_CURRENTLY_ON(content::BrowserThread::FILE); 46 DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);
47 47
48 // Try to read an existing GUID. 48 // Try to read an existing GUID.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 metrics_state_manager_ = metrics::MetricsStateManager::Create( 100 metrics_state_manager_ = metrics::MetricsStateManager::Create(
101 pref_service_, base::Bind(&AwMetricsServiceClient::is_reporting_enabled, 101 pref_service_, base::Bind(&AwMetricsServiceClient::is_reporting_enabled,
102 base::Unretained(this)), 102 base::Unretained(this)),
103 base::Bind(&StoreClientInfo), base::Bind(&LoadClientInfo)); 103 base::Bind(&StoreClientInfo), base::Bind(&LoadClientInfo));
104 104
105 metrics_service_.reset(new ::metrics::MetricsService( 105 metrics_service_.reset(new ::metrics::MetricsService(
106 metrics_state_manager_.get(), this, pref_service_)); 106 metrics_state_manager_.get(), this, pref_service_));
107 107
108 metrics_service_->RegisterMetricsProvider( 108 metrics_service_->RegisterMetricsProvider(
109 scoped_ptr<metrics::MetricsProvider>(new metrics::NetworkMetricsProvider( 109 std::unique_ptr<metrics::MetricsProvider>(
110 content::BrowserThread::GetBlockingPool()))); 110 new metrics::NetworkMetricsProvider(
111 content::BrowserThread::GetBlockingPool())));
111 112
112 metrics_service_->RegisterMetricsProvider( 113 metrics_service_->RegisterMetricsProvider(
113 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider)); 114 std::unique_ptr<metrics::MetricsProvider>(
115 new metrics::GPUMetricsProvider));
114 116
115 metrics_service_->RegisterMetricsProvider( 117 metrics_service_->RegisterMetricsProvider(
116 scoped_ptr<metrics::MetricsProvider>( 118 std::unique_ptr<metrics::MetricsProvider>(
117 new metrics::ScreenInfoMetricsProvider)); 119 new metrics::ScreenInfoMetricsProvider));
118 120
119 metrics_service_->RegisterMetricsProvider( 121 metrics_service_->RegisterMetricsProvider(
120 scoped_ptr<metrics::MetricsProvider>( 122 std::unique_ptr<metrics::MetricsProvider>(
121 new metrics::ProfilerMetricsProvider())); 123 new metrics::ProfilerMetricsProvider()));
122 124
123 metrics_service_->RegisterMetricsProvider( 125 metrics_service_->RegisterMetricsProvider(
124 scoped_ptr<metrics::MetricsProvider>( 126 std::unique_ptr<metrics::MetricsProvider>(
125 new metrics::CallStackProfileMetricsProvider)); 127 new metrics::CallStackProfileMetricsProvider));
126 128
127 metrics_service_->InitializeMetricsRecordingState(); 129 metrics_service_->InitializeMetricsRecordingState();
128 130
129 is_initialized_ = true; 131 is_initialized_ = true;
130 132
131 if (is_reporting_enabled()) 133 if (is_reporting_enabled())
132 metrics_service_->Start(); 134 metrics_service_->Start();
133 } 135 }
134 136
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 void AwMetricsServiceClient::InitializeSystemProfileMetrics( 194 void AwMetricsServiceClient::InitializeSystemProfileMetrics(
193 const base::Closure& done_callback) { 195 const base::Closure& done_callback) {
194 done_callback.Run(); 196 done_callback.Run();
195 } 197 }
196 198
197 void AwMetricsServiceClient::CollectFinalMetricsForLog( 199 void AwMetricsServiceClient::CollectFinalMetricsForLog(
198 const base::Closure& done_callback) { 200 const base::Closure& done_callback) {
199 done_callback.Run(); 201 done_callback.Run();
200 } 202 }
201 203
202 scoped_ptr<metrics::MetricsLogUploader> AwMetricsServiceClient::CreateUploader( 204 std::unique_ptr<metrics::MetricsLogUploader>
205 AwMetricsServiceClient::CreateUploader(
203 const base::Callback<void(int)>& on_upload_complete) { 206 const base::Callback<void(int)>& on_upload_complete) {
204 return scoped_ptr<::metrics::MetricsLogUploader>( 207 return std::unique_ptr<::metrics::MetricsLogUploader>(
205 new metrics::NetMetricsLogUploader( 208 new metrics::NetMetricsLogUploader(
206 request_context_, 209 request_context_, metrics::kDefaultMetricsServerUrl,
207 metrics::kDefaultMetricsServerUrl, 210 metrics::kDefaultMetricsMimeType, on_upload_complete));
208 metrics::kDefaultMetricsMimeType,
209 on_upload_complete));
210 } 211 }
211 212
212 base::TimeDelta AwMetricsServiceClient::GetStandardUploadInterval() { 213 base::TimeDelta AwMetricsServiceClient::GetStandardUploadInterval() {
213 return base::TimeDelta::FromMinutes(kUploadIntervalMinutes); 214 return base::TimeDelta::FromMinutes(kUploadIntervalMinutes);
214 } 215 }
215 216
216 AwMetricsServiceClient::AwMetricsServiceClient() 217 AwMetricsServiceClient::AwMetricsServiceClient()
217 : is_initialized_(false), 218 : is_initialized_(false),
218 is_enabled_(false), 219 is_enabled_(false),
219 pref_service_(nullptr), 220 pref_service_(nullptr),
220 request_context_(nullptr) {} 221 request_context_(nullptr) {}
221 222
222 AwMetricsServiceClient::~AwMetricsServiceClient() {} 223 AwMetricsServiceClient::~AwMetricsServiceClient() {}
223 224
224 bool AwMetricsServiceClient::is_reporting_enabled() { 225 bool AwMetricsServiceClient::is_reporting_enabled() {
225 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 226 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
226 return is_enabled_; 227 return is_enabled_;
227 } 228 }
228 229
229 } // namespace android_webview 230 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/aw_metrics_service_client.h ('k') | android_webview/browser/aw_permission_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698