android_webview/browser/browser_view_renderer.h - Issue 1852513003: Convert //android_webview to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 1852513003: Convert //android_webview to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git is hard Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/browser_view_renderer.h

diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h

index c3c530f4307222721031c165bd1a22ad59f2bc31..60fc097d4b0098b637ba9968a5cf4165d33679a3 100644

--- a/android_webview/browser/browser_view_renderer.h

+++ b/android_webview/browser/browser_view_renderer.h

@@ -128,11 +128,11 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {

bool CanOnDraw();

void UpdateCompositorIsActive();

bool CompositeSW(SkCanvas* canvas);

- scoped_ptr<base::trace_event::ConvertableToTraceFormat> RootLayerStateAsValue(

- const gfx::Vector2dF& total_scroll_offset_dip,

- const gfx::SizeF& scrollable_size_dip);

+ std::unique_ptr<base::trace_event::ConvertableToTraceFormat>

+ RootLayerStateAsValue(const gfx::Vector2dF& total_scroll_offset_dip,

+ const gfx::SizeF& scrollable_size_dip);

- void ReturnUnusedResource(scoped_ptr<ChildFrame> frame);

+ void ReturnUnusedResource(std::unique_ptr<ChildFrame> frame);

void ReturnResourceFromParent();

gfx::Vector2d max_scroll_offset() const;