android_webview/native/java_browser_view_renderer_helper.h - Issue 1852513003: Convert //android_webview to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/java_browser_view_renderer_helper.h

Issue 1852513003: Convert //android_webview to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git is hard Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/java_browser_view_renderer_helper.h

diff --git a/android_webview/native/java_browser_view_renderer_helper.h b/android_webview/native/java_browser_view_renderer_helper.h

index 874f008e2da21523303d0b4cfe95aab4c4545c6e..ba8b3b4703eef267b018a23cedce56a86f896a8e 100644

--- a/android_webview/native/java_browser_view_renderer_helper.h

+++ b/android_webview/native/java_browser_view_renderer_helper.h

@@ -7,7 +7,8 @@

#include <jni.h>

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "skia/ext/refptr.h"

#include "ui/gfx/geometry/size.h"

#include "ui/gfx/geometry/vector2d.h"

@@ -19,7 +20,7 @@ namespace android_webview {

class SoftwareCanvasHolder {

public:

- static scoped_ptr<SoftwareCanvasHolder> Create(

+ static std::unique_ptr<SoftwareCanvasHolder> Create(

jobject java_canvas,

const gfx::Vector2d& scroll_correction,

const gfx::Size& auxiliary_bitmap_size,