Fix NSPasteboard leaks.

Fix NSPasteboard leaks.

This CL adds a new Scoped C++ class that correctly destroys an NSPasteboard
created from -[NSPasteboard pasteboardWithUniqueName].

BUG=467296
Committed: https://crrev.com/d9b76f0f70ec99842159e252e414a495377f0aec
Cr-Commit-Position: refs/heads/master@{#384697}

[erikchen, 2016-04-01 18:00:03]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-04-01 18:00:04]

avi: Please review.

[dcheng, 2016-04-01 18:04:50]

Wow, thanks for finding this.

It sure would be nice if
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Applica...
mentioned this: what are the chances we can get Apple to update their
documentation?

[Avi (use Gerrit), 2016-04-01 18:21:01]

lgtm

https://codereview.chromium.org/1852433004/diff/1/ui/base/clipboard/clipboard...
File ui/base/clipboard/clipboard_util_mac.mm (right):

https://codereview.chromium.org/1852433004/diff/1/ui/base/clipboard/clipboard...
ui/base/clipboard/clipboard_util_mac.mm:33: [pasteboard_ releaseGlobally];
OMG

Yes, the docs imply this, but this isn't at all obvious.

o_O

[erikchen, 2016-04-01 19:00:58]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-04-01 19:01:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433004/1

[commit-bot: I haz the power, 2016-04-01 19:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 19:45:50]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[erikchen, 2016-04-01 20:25:43]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-01 20:25:43]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1852433004/#ps20001
(title: "Fix compile error.")

[commit-bot: I haz the power, 2016-04-01 20:26:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852433004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852433004/20001

[commit-bot: I haz the power, 2016-04-01 21:49:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 21:52:27]

Description was changed from

==========
Fix NSPasteboard leaks.

This CL adds a new Scoped C++ class that correctly destroys an NSPasteboard
created from -[NSPasteboard pasteboardWithUniqueName].

BUG=467296
==========

to

==========
Fix NSPasteboard leaks.

This CL adds a new Scoped C++ class that correctly destroys an NSPasteboard
created from -[NSPasteboard pasteboardWithUniqueName].

BUG=467296

Committed: https://crrev.com/d9b76f0f70ec99842159e252e414a495377f0aec
Cr-Commit-Position: refs/heads/master@{#384697}
==========

[commit-bot: I haz the power, 2016-04-01 21:52:28]

Patchset 2 (id:??) landed as
https://crrev.com/d9b76f0f70ec99842159e252e414a495377f0aec
Cr-Commit-Position: refs/heads/master@{#384697}