Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: ui/base/clipboard/clipboard_util_mac_unittest.mm

Issue 1852433004: Fix NSPasteboard leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ui/base/clipboard/clipboard_util_mac.h" 5 #import "ui/base/clipboard/clipboard_util_mac.h"
6 6
7 #include "base/mac/scoped_nsobject.h" 7 #include "base/mac/scoped_nsobject.h"
8 #include "base/memory/ref_counted.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 #include "testing/gtest_mac.h" 10 #include "testing/gtest_mac.h"
10 #include "testing/platform_test.h" 11 #include "testing/platform_test.h"
11 #include "third_party/mozilla/NSPasteboard+Utils.h" 12 #include "third_party/mozilla/NSPasteboard+Utils.h"
12 13
13 namespace { 14 namespace {
14 15
15 class ClipboardUtilMacTest : public PlatformTest { 16 class ClipboardUtilMacTest : public PlatformTest {
16 public: 17 public:
17 ClipboardUtilMacTest() { } 18 ClipboardUtilMacTest() { }
18 }; 19 };
19 20
20 TEST_F(ClipboardUtilMacTest, PasteboardItemFromUrl) { 21 TEST_F(ClipboardUtilMacTest, PasteboardItemFromUrl) {
21 NSString* urlString = 22 NSString* urlString =
22 @"https://www.google.com/" 23 @"https://www.google.com/"
23 @"search?q=test&oq=test&aqs=chrome..69i57l2j69i60l4.278j0j7&" 24 @"search?q=test&oq=test&aqs=chrome..69i57l2j69i60l4.278j0j7&"
24 @"sourceid=chrome&ie=UTF-8"; 25 @"sourceid=chrome&ie=UTF-8";
25 26
26 base::scoped_nsobject<NSPasteboardItem> item( 27 base::scoped_nsobject<NSPasteboardItem> item(
27 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, nil)); 28 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, nil));
28 NSPasteboard* pasteboard = [NSPasteboard pasteboardWithUniqueName]; 29 scoped_refptr<ui::UniquePasteboard> pasteboard = new ui::UniquePasteboard;
29 [pasteboard writeObjects:@[ item ]]; 30 [pasteboard->get() writeObjects:@[ item ]];
30 31
31 NSArray* urls = nil; 32 NSArray* urls = nil;
32 NSArray* titles = nil; 33 NSArray* titles = nil;
33 [pasteboard getURLs:&urls andTitles:&titles convertingFilenames:NO]; 34 [pasteboard->get() getURLs:&urls andTitles:&titles convertingFilenames:NO];
34 35
35 ASSERT_EQ(1u, [urls count]); 36 ASSERT_EQ(1u, [urls count]);
36 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]); 37 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]);
37 ASSERT_EQ(1u, [titles count]); 38 ASSERT_EQ(1u, [titles count]);
38 EXPECT_NSEQ(urlString, [titles objectAtIndex:0]); 39 EXPECT_NSEQ(urlString, [titles objectAtIndex:0]);
39 40
40 NSURL* url = [NSURL URLFromPasteboard:pasteboard]; 41 NSURL* url = [NSURL URLFromPasteboard:pasteboard->get()];
41 EXPECT_NSEQ([url absoluteString], urlString); 42 EXPECT_NSEQ([url absoluteString], urlString);
42 } 43 }
43 44
44 TEST_F(ClipboardUtilMacTest, PasteboardItemWithTitle) { 45 TEST_F(ClipboardUtilMacTest, PasteboardItemWithTitle) {
45 NSString* urlString = @"https://www.google.com/"; 46 NSString* urlString = @"https://www.google.com/";
46 NSString* title = @"Burrowing Yams"; 47 NSString* title = @"Burrowing Yams";
47 48
48 base::scoped_nsobject<NSPasteboardItem> item( 49 base::scoped_nsobject<NSPasteboardItem> item(
49 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, title)); 50 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, title));
50 NSPasteboard* pasteboard = [NSPasteboard pasteboardWithUniqueName]; 51 scoped_refptr<ui::UniquePasteboard> pasteboard = new ui::UniquePasteboard;
51 [pasteboard writeObjects:@[ item ]]; 52 [pasteboard->get() writeObjects:@[ item ]];
52 53
53 NSArray* urls = nil; 54 NSArray* urls = nil;
54 NSArray* titles = nil; 55 NSArray* titles = nil;
55 [pasteboard getURLs:&urls andTitles:&titles convertingFilenames:NO]; 56 [pasteboard->get() getURLs:&urls andTitles:&titles convertingFilenames:NO];
56 57
57 ASSERT_EQ(1u, [urls count]); 58 ASSERT_EQ(1u, [urls count]);
58 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]); 59 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]);
59 ASSERT_EQ(1u, [titles count]); 60 ASSERT_EQ(1u, [titles count]);
60 EXPECT_NSEQ(title, [titles objectAtIndex:0]); 61 EXPECT_NSEQ(title, [titles objectAtIndex:0]);
61 62
62 NSURL* url = [NSURL URLFromPasteboard:pasteboard]; 63 NSURL* url = [NSURL URLFromPasteboard:pasteboard->get()];
63 EXPECT_NSEQ([url absoluteString], urlString); 64 EXPECT_NSEQ([url absoluteString], urlString);
64 } 65 }
65 66
66 TEST_F(ClipboardUtilMacTest, PasteboardItemWithFilePath) { 67 TEST_F(ClipboardUtilMacTest, PasteboardItemWithFilePath) {
67 NSURL* url = [NSURL fileURLWithPath:NSTemporaryDirectory() isDirectory:YES]; 68 NSURL* url = [NSURL fileURLWithPath:NSTemporaryDirectory() isDirectory:YES];
68 ASSERT_TRUE(url); 69 ASSERT_TRUE(url);
69 NSString* urlString = [url absoluteString]; 70 NSString* urlString = [url absoluteString];
70 71
71 base::scoped_nsobject<NSPasteboardItem> item( 72 base::scoped_nsobject<NSPasteboardItem> item(
72 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, nil)); 73 ui::ClipboardUtil::PasteboardItemFromUrl(urlString, nil));
73 NSPasteboard* pasteboard = [NSPasteboard pasteboardWithUniqueName]; 74 scoped_refptr<ui::UniquePasteboard> pasteboard = new ui::UniquePasteboard;
74 [pasteboard writeObjects:@[ item ]]; 75 [pasteboard->get() writeObjects:@[ item ]];
75 76
76 NSArray* urls = nil; 77 NSArray* urls = nil;
77 NSArray* titles = nil; 78 NSArray* titles = nil;
78 [pasteboard getURLs:&urls andTitles:&titles convertingFilenames:NO]; 79 [pasteboard->get() getURLs:&urls andTitles:&titles convertingFilenames:NO];
79 80
80 ASSERT_EQ(1u, [urls count]); 81 ASSERT_EQ(1u, [urls count]);
81 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]); 82 EXPECT_NSEQ(urlString, [urls objectAtIndex:0]);
82 ASSERT_EQ(1u, [titles count]); 83 ASSERT_EQ(1u, [titles count]);
83 EXPECT_NSEQ(urlString, [titles objectAtIndex:0]); 84 EXPECT_NSEQ(urlString, [titles objectAtIndex:0]);
84 85
85 NSURL* urlFromPasteboard = [NSURL URLFromPasteboard:pasteboard]; 86 NSURL* urlFromPasteboard = [NSURL URLFromPasteboard:pasteboard->get()];
86 EXPECT_NSEQ(urlFromPasteboard, url); 87 EXPECT_NSEQ(urlFromPasteboard, url);
87 } 88 }
88 89
90 TEST_F(ClipboardUtilMacTest, CheckForLeak) {
91 for (int i = 0; i < 10000; ++i) {
92 @autoreleasepool {
93 scoped_refptr<ui::UniquePasteboard> pboard = new ui::UniquePasteboard;
94 EXPECT_TRUE(pboard->get());
95 }
96 }
97 }
98
89 } // namespace 99 } // namespace
OLDNEW
« no previous file with comments | « ui/base/clipboard/clipboard_util_mac.mm ('k') | ui/base/dragdrop/os_exchange_data_provider_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698