Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: content/browser/web_contents/web_drag_source_mac_unittest.mm

Issue 1852433004: Fix NSPasteboard leaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_drag_source_mac_unittest.mm
diff --git a/content/browser/web_contents/web_drag_source_mac_unittest.mm b/content/browser/web_contents/web_drag_source_mac_unittest.mm
index 036c9268f8e94c26d8a7be1736dd8e1bc8f4cb4e..edc188848108265a84a576cccab8be289cf7576f 100644
--- a/content/browser/web_contents/web_drag_source_mac_unittest.mm
+++ b/content/browser/web_contents/web_drag_source_mac_unittest.mm
@@ -4,10 +4,12 @@
#import "content/browser/web_contents/web_drag_source_mac.h"
+#include "base/memory/ref_counted.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/common/drop_data.h"
#include "content/public/test/test_renderer_host.h"
#include "testing/gtest/include/gtest/gtest.h"
+#import "ui/base/clipboard/clipboard_util_mac.h"
#include "url/gurl.h"
namespace content {
@@ -23,19 +25,19 @@ TEST_F(WebDragSourceMacTest, DragInvalidlyEscapedBookmarklet) {
dropData->url = GURL("javascript:%");
WebContentsImpl* contentsImpl = static_cast<WebContentsImpl*>(contents.get());
+ scoped_refptr<ui::UniquePasteboard> pasteboard1 = new ui::UniquePasteboard;
base::scoped_nsobject<WebDragSource> source([[WebDragSource alloc]
- initWithContents:contentsImpl
- view:view
- dropData:dropData.get()
- image:nil
- offset:NSZeroPoint
- pasteboard:[NSPasteboard pasteboardWithUniqueName]
- dragOperationMask:NSDragOperationCopy]);
+ initWithContents:contentsImpl
+ view:view
+ dropData:dropData.get()
+ image:nil
+ offset:NSZeroPoint
+ pasteboard:pasteboard1->get()
+ dragOperationMask:NSDragOperationCopy]);
// Test that this call doesn't throw any exceptions: http://crbug.com/128371
- base::scoped_nsobject<NSPasteboard> pasteboard(
- [NSPasteboard pasteboardWithUniqueName]);
- [source lazyWriteToPasteboard:pasteboard forType:NSURLPboardType];
+ scoped_refptr<ui::UniquePasteboard> pasteboard2 = new ui::UniquePasteboard;
+ [source lazyWriteToPasteboard:pasteboard2->get() forType:NSURLPboardType];
}
} // namespace content
« no previous file with comments | « content/browser/web_contents/web_drag_dest_mac_unittest.mm ('k') | content/common/sandbox_mac_system_access_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698