Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

This CL also fixes some improper uses of NSPasteboard in clipboard_mac.mm.

BUG=592663
Committed: https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28
Cr-Commit-Position: refs/heads/master@{#384739}

[erikchen, 2016-03-30 19:46:15]

Description was changed from

==========
Fix use of deprecated dragging API on OS X.

BUG=
==========

to

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

BUG=592663
==========

[erikchen, 2016-03-30 19:47:28]

Description was changed from

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

BUG=592663
==========

to

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

BUG=592663
==========

[erikchen, 2016-03-30 19:47:58]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-03-30 19:47:59]

mark: Please review.

[Mark Mentovai, 2016-03-30 19:59:08]

LGTM

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:29: //
Set to true when an instance of this class is running a nested run loop.
Add a few words on why it’s desirable for this to be global instead of
per-instance.

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:130:
gInDrag = true;
DCHECK(!gInDrag);

[erikchen, 2016-03-30 20:05:29]

note: I manually tested that dragging from omnibox still works.

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:29: //
Set to true when an instance of this class is running a nested run loop.
On 2016/03/30 19:59:08, Mark Mentovai wrote:
> Add a few words on why it’s desirable for this to be global instead of
> per-instance.

Done:

"""
30 // Since this must always be run on the UI thread, there should never be two
  31 // simultaneous drags.
"""

https://codereview.chromium.org/1841813002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:130:
gInDrag = true;
On 2016/03/30 19:59:08, Mark Mentovai wrote:
> DCHECK(!gInDrag);

Done.

[erikchen, 2016-03-30 20:05:34]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-30 20:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1841813002/#ps80001
(title: "Comments from mark@.")

[commit-bot: I haz the power, 2016-03-30 20:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/80001

[Mark Mentovai, 2016-03-30 20:06:49]

LGTM

[commit-bot: I haz the power, 2016-03-30 20:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:42:38]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-30 20:45:51]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-30 20:45:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1841813002/#ps100001
(title: "Compile error.")

[commit-bot: I haz the power, 2016-03-30 20:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/100001

[commit-bot: I haz the power, 2016-03-30 22:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:20:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-31 20:58:23]

Description was changed from

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

BUG=592663
==========

to

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

This CL also fixes some improper uses of NSPasteboard in clipboard_mac.mm.

BUG=592663
==========

[erikchen, 2016-03-31 20:58:34]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-03-31 20:58:35]

avi: Please review ui/

[erikchen, 2016-03-31 21:00:23]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 21:00:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/120001

[Avi (use Gerrit), 2016-03-31 21:17:07]

LGTM

[commit-bot: I haz the power, 2016-03-31 23:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 23:59:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-01 19:59:40]

avi: Please review the diff between patch sets 7 and 8. I'm not super happy
about the change to clipboard_util_mac.mm, but otherwise it overwrites the text
added by ClipboardMac::WriteText.

[Avi (use Gerrit), 2016-04-01 20:04:52]

Weird. Still lgtm.

[erikchen, 2016-04-01 20:29:38]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:30:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/160001

[erikchen, 2016-04-01 20:36:06]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-04-01 21:03:52]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 21:04:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/180001

[erikchen, 2016-04-01 21:10:55]

Patchset #10 (id:180001) has been deleted

[commit-bot: I haz the power, 2016-04-01 21:13:36]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-04-01 21:32:07]

avi: Please review, again. Sorry.

Based on the fact that ClipboardMac::WriteBookmark calls addTypes: instead of
setTypes:, don't overwrite the previous data. This also allows bookmarks to
continue to set NSStringPboardType, which is important for integration with
other applications.

[Avi (use Gerrit), 2016-04-01 22:31:25]

lgtm

Nits.

https://codereview.chromium.org/1841813002/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1841813002/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:26: @end
base/mac/sdk_forward_declarations.h ?

https://codereview.chromium.org/1841813002/diff/200001/ui/base/clipboard/clip...
File ui/base/clipboard/clipboard_mac.mm (right):

https://codereview.chromium.org/1841813002/diff/200001/ui/base/clipboard/clip...
ui/base/clipboard/clipboard_mac.mm:436: for (NSString* type in newTypesArray) {
[pb addTypes:[newTypes allObjects] owner:nil];
for(NSString* type in newTypes) {
// ...

Then you can drop the newTypesArray line.

[erikchen, 2016-04-01 22:41:09]

https://codereview.chromium.org/1841813002/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

https://codereview.chromium.org/1841813002/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:26: @end
On 2016/04/01 22:31:25, Avi wrote:
> base/mac/sdk_forward_declarations.h ?

Done.

https://codereview.chromium.org/1841813002/diff/200001/ui/base/clipboard/clip...
File ui/base/clipboard/clipboard_mac.mm (right):

https://codereview.chromium.org/1841813002/diff/200001/ui/base/clipboard/clip...
ui/base/clipboard/clipboard_mac.mm:436: for (NSString* type in newTypesArray) {
On 2016/04/01 22:31:25, Avi wrote:
> [pb addTypes:[newTypes allObjects] owner:nil];
> for(NSString* type in newTypes) {
> // ...
> 
> Then you can drop the newTypesArray line.

Done.

[erikchen, 2016-04-01 22:41:16]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-01 22:41:17]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1841813002/#ps220001
(title: "Comments from avi.")

[commit-bot: I haz the power, 2016-04-01 22:42:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841813002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841813002/220001

[commit-bot: I haz the power, 2016-04-02 00:03:54]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-04-02 00:05:22]

Description was changed from

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

This CL also fixes some improper uses of NSPasteboard in clipboard_mac.mm.

BUG=592663
==========

to

==========
Update AutocompleteTextFieldEditor to use non-deprecated dragging APIs.

This CL theoretically should not produce any behavior change.

This CL replaces the method -[NSView dragImage:...] with -[NSView
beginDraggingSessionWithItems:...]. There are two major differences.

1. The new API is asynchronous, whereas the old one ran a nested run loop. This
CL runs a nested run loop to maintain the previous behavior.
2. The new API makes use of some new terminology and protocols
(NSDraggingSession) but the underlying logic is still the same.

This CL also fixes some improper uses of NSPasteboard in clipboard_mac.mm.

BUG=592663

Committed: https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28
Cr-Commit-Position: refs/heads/master@{#384739}
==========

[commit-bot: I haz the power, 2016-04-02 00:05:25]

Patchset 11 (id:??) landed as
https://crrev.com/df2f225a8b0e9bb797a0a8667ea601ac67941e28
Cr-Commit-Position: refs/heads/master@{#384739}