Implement SpdySerializedFrame move semantics.

Implement SpdySerializedFrame move semantics.

* Rename SpdyFrame to SpdySerializedFrame everywhere.  (It was already
  called that at a number of places.)  Remove typedef.
* Add move constructor and move assignment operator.
* Change return value from SpdySerializedFrame* to SpdySerializedFrame for
  SpdyFramer methods and SpdyFrameBuilder::take().
* Remove scoped_ptr.get() == nullptr checks which could never possibly be true anyway.
* Merge SpdySerializedFrame instantiation and assignment in a few tests (except
  where lifetime requirements would not allow it.)
* Remove declaration of undefined, unused method SpdyFramer::CompressFrame().
* Remove unused variable |uncompressed| from SpdyFramerTest.Basic.
* git clang-format.

This cuts down on SpdySerializedFrame allocations, and also trigger compiler
errors for unused local variables.  (Unused scoped_ptr<>'s like |uncompressed|
did not trigger an error.)

This is a minimal CL to land server change 117967994 by bnc.  It will be
followed up by other CLs moving instances of SpdySerializedFramer from heap to
stack.

BUG=488484, 600438
Committed: https://crrev.com/b03b109170504bbf5cea0a33327574196bc21c76
Cr-Commit-Position: refs/heads/master@{#385436}

[Bence, 2016-04-05 16:46:26]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-04-05 16:46:27]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-04-06 04:33:05]

lgtm

[Bence, 2016-04-06 11:14:17]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-04-06 11:14:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1852423004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1852423004/1

[commit-bot: I haz the power, 2016-04-06 11:20:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 11:21:29]

Description was changed from

==========
Implement SpdySerializedFrame move semantics.

* Rename SpdyFrame to SpdySerializedFrame everywhere.  (It was already
  called that at a number of places.)  Remove typedef.
* Add move constructor and move assignment operator.
* Change return value from SpdySerializedFrame* to SpdySerializedFrame for
  SpdyFramer methods and SpdyFrameBuilder::take().
* Remove scoped_ptr.get() == nullptr checks which could never possibly be true
anyway.
* Merge SpdySerializedFrame instantiation and assignment in a few tests (except
  where lifetime requirements would not allow it.)
* Remove declaration of undefined, unused method SpdyFramer::CompressFrame().
* Remove unused variable |uncompressed| from SpdyFramerTest.Basic.
* git clang-format.

This cuts down on SpdySerializedFrame allocations, and also trigger compiler
errors for unused local variables.  (Unused scoped_ptr<>'s like |uncompressed|
did not trigger an error.)

This is a minimal CL to land server change 117967994 by bnc.  It will be
followed up by other CLs moving instances of SpdySerializedFramer from heap to
stack.

BUG=488484, 600438
==========

to

==========
Implement SpdySerializedFrame move semantics.

* Rename SpdyFrame to SpdySerializedFrame everywhere.  (It was already
  called that at a number of places.)  Remove typedef.
* Add move constructor and move assignment operator.
* Change return value from SpdySerializedFrame* to SpdySerializedFrame for
  SpdyFramer methods and SpdyFrameBuilder::take().
* Remove scoped_ptr.get() == nullptr checks which could never possibly be true
anyway.
* Merge SpdySerializedFrame instantiation and assignment in a few tests (except
  where lifetime requirements would not allow it.)
* Remove declaration of undefined, unused method SpdyFramer::CompressFrame().
* Remove unused variable |uncompressed| from SpdyFramerTest.Basic.
* git clang-format.

This cuts down on SpdySerializedFrame allocations, and also trigger compiler
errors for unused local variables.  (Unused scoped_ptr<>'s like |uncompressed|
did not trigger an error.)

This is a minimal CL to land server change 117967994 by bnc.  It will be
followed up by other CLs moving instances of SpdySerializedFramer from heap to
stack.

BUG=488484, 600438

Committed: https://crrev.com/b03b109170504bbf5cea0a33327574196bc21c76
Cr-Commit-Position: refs/heads/master@{#385436}
==========

[commit-bot: I haz the power, 2016-04-06 11:21:30]

Patchset 1 (id:??) landed as
https://crrev.com/b03b109170504bbf5cea0a33327574196bc21c76
Cr-Commit-Position: refs/heads/master@{#385436}