Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 1852423004: Implement SpdySerializedFrame move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_packet_maker.cc ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer.h
diff --git a/net/spdy/buffered_spdy_framer.h b/net/spdy/buffered_spdy_framer.h
index 65460bbd1bdad3083d2e621b780f497445e4ee2d..8ad0defed0f0477ef4eb99f1feb01b743661f40c 100644
--- a/net/spdy/buffered_spdy_framer.h
+++ b/net/spdy/buffered_spdy_framer.h
@@ -29,7 +29,7 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramerVisitorInterface {
public:
BufferedSpdyFramerVisitorInterface() {}
- // Called if an error is detected in the SpdyFrame protocol.
+ // Called if an error is detected in the SpdySerializedFrame protocol.
virtual void OnError(SpdyFramer::SpdyError error_code) = 0;
// Called if an error is detected in a SPDY stream.
@@ -213,37 +213,37 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
SpdyFramer::SpdyState state() const;
bool MessageFullyRead();
bool HasError();
- SpdyFrame* CreateSynStream(SpdyStreamId stream_id,
- SpdyStreamId associated_stream_id,
- SpdyPriority priority,
- SpdyControlFlags flags,
- const SpdyHeaderBlock* headers);
- SpdyFrame* CreateSynReply(SpdyStreamId stream_id,
- SpdyControlFlags flags,
- const SpdyHeaderBlock* headers);
- SpdyFrame* CreateRstStream(SpdyStreamId stream_id,
- SpdyRstStreamStatus status) const;
- SpdyFrame* CreateSettings(const SettingsMap& values) const;
- SpdyFrame* CreatePingFrame(SpdyPingId unique_id, bool is_ack) const;
- SpdyFrame* CreateGoAway(SpdyStreamId last_accepted_stream_id,
- SpdyGoAwayStatus status,
- base::StringPiece debug_data) const;
- SpdyFrame* CreateHeaders(SpdyStreamId stream_id,
- SpdyControlFlags flags,
- SpdyPriority priority,
- const SpdyHeaderBlock* headers);
- SpdyFrame* CreateWindowUpdate(SpdyStreamId stream_id,
- uint32_t delta_window_size) const;
- SpdyFrame* CreateDataFrame(SpdyStreamId stream_id,
- const char* data,
- uint32_t len,
- SpdyDataFlags flags);
- SpdyFrame* CreatePushPromise(SpdyStreamId stream_id,
- SpdyStreamId promised_stream_id,
- const SpdyHeaderBlock* headers);
+ SpdySerializedFrame* CreateSynStream(SpdyStreamId stream_id,
+ SpdyStreamId associated_stream_id,
+ SpdyPriority priority,
+ SpdyControlFlags flags,
+ const SpdyHeaderBlock* headers);
+ SpdySerializedFrame* CreateSynReply(SpdyStreamId stream_id,
+ SpdyControlFlags flags,
+ const SpdyHeaderBlock* headers);
+ SpdySerializedFrame* CreateRstStream(SpdyStreamId stream_id,
+ SpdyRstStreamStatus status) const;
+ SpdySerializedFrame* CreateSettings(const SettingsMap& values) const;
+ SpdySerializedFrame* CreatePingFrame(SpdyPingId unique_id, bool is_ack) const;
+ SpdySerializedFrame* CreateGoAway(SpdyStreamId last_accepted_stream_id,
+ SpdyGoAwayStatus status,
+ base::StringPiece debug_data) const;
+ SpdySerializedFrame* CreateHeaders(SpdyStreamId stream_id,
+ SpdyControlFlags flags,
+ SpdyPriority priority,
+ const SpdyHeaderBlock* headers);
+ SpdySerializedFrame* CreateWindowUpdate(SpdyStreamId stream_id,
+ uint32_t delta_window_size) const;
+ SpdySerializedFrame* CreateDataFrame(SpdyStreamId stream_id,
+ const char* data,
+ uint32_t len,
+ SpdyDataFlags flags);
+ SpdySerializedFrame* CreatePushPromise(SpdyStreamId stream_id,
+ SpdyStreamId promised_stream_id,
+ const SpdyHeaderBlock* headers);
// Serialize a frame of unknown type.
- SpdySerializedFrame* SerializeFrame(const SpdyFrameIR& frame) {
+ SpdySerializedFrame SerializeFrame(const SpdyFrameIR& frame) {
return spdy_framer_.SerializeFrame(frame);
}
« no previous file with comments | « net/quic/test_tools/quic_test_packet_maker.cc ('k') | net/spdy/buffered_spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698