net/spdy/spdy_write_queue_unittest.cc - Issue 1852423004: Implement SpdySerializedFrame move semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_write_queue_unittest.cc

Issue 1852423004: Implement SpdySerializedFrame move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_write_queue_unittest.cc

diff --git a/net/spdy/spdy_write_queue_unittest.cc b/net/spdy/spdy_write_queue_unittest.cc

index 1c7bc0a880510fdde7b12486635664d47872c099..da9d98778f74df5af34bbe95e01129e04358be0d 100644

--- a/net/spdy/spdy_write_queue_unittest.cc

+++ b/net/spdy/spdy_write_queue_unittest.cc

@@ -35,12 +35,9 @@ class SpdyWriteQueueTest : public ::testing::Test {};

scoped_ptr<SpdyBufferProducer> StringToProducer(const std::string& s) {

scoped_ptr<char[]> data(new char[s.size()]);

std::memcpy(data.get(), s.data(), s.size());

- return scoped_ptr<SpdyBufferProducer>(

- new SimpleBufferProducer(

- scoped_ptr<SpdyBuffer>(

- new SpdyBuffer(

- scoped_ptr<SpdyFrame>(

- new SpdyFrame(data.release(), s.size(), true))))));

+ return scoped_ptr<SpdyBufferProducer>(new SimpleBufferProducer(

+ scoped_ptr<SpdyBuffer>(new SpdyBuffer(scoped_ptr<SpdySerializedFrame>(

+ new SpdySerializedFrame(data.release(), s.size(), true))))));

}

// Makes a SpdyBufferProducer producing a frame with the data in the

« no previous file with comments | « net/spdy/spdy_test_utils.cc ('k') | net/tools/flip_server/spdy_interface.cc » ('j') | no next file with comments »