Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: net/quic/test_tools/quic_test_packet_maker.cc

Issue 1852423004: Implement SpdySerializedFrame move semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/spdy_utils.cc ('k') | net/spdy/buffered_spdy_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_packet_maker.cc
diff --git a/net/quic/test_tools/quic_test_packet_maker.cc b/net/quic/test_tools/quic_test_packet_maker.cc
index 58e06c9902a6244132831f29043f8c95f0252afa..67e0ffa91fdde9b2c488a219d867579143cfa3a9 100644
--- a/net/quic/test_tools/quic_test_packet_maker.cc
+++ b/net/quic/test_tools/quic_test_packet_maker.cc
@@ -341,34 +341,34 @@ scoped_ptr<QuicReceivedPacket> QuicTestPacketMaker::MakeRequestHeadersPacket(
size_t* spdy_headers_frame_length,
QuicStreamOffset* offset) {
InitializeHeader(packet_number, should_include_version);
- scoped_ptr<SpdySerializedFrame> spdy_frame;
+ SpdySerializedFrame spdy_frame;
if (spdy_request_framer_.protocol_version() == SPDY3) {
SpdySynStreamIR syn_stream(stream_id);
syn_stream.set_header_block(headers);
syn_stream.set_fin(fin);
syn_stream.set_priority(priority);
- spdy_frame.reset(spdy_request_framer_.SerializeSynStream(syn_stream));
+ spdy_frame = spdy_request_framer_.SerializeSynStream(syn_stream);
} else {
SpdyHeadersIR headers_frame(stream_id);
headers_frame.set_header_block(headers);
headers_frame.set_fin(fin);
headers_frame.set_priority(priority);
headers_frame.set_has_priority(true);
- spdy_frame.reset(spdy_request_framer_.SerializeFrame(headers_frame));
+ spdy_frame = spdy_request_framer_.SerializeFrame(headers_frame);
}
if (spdy_headers_frame_length) {
- *spdy_headers_frame_length = spdy_frame->size();
+ *spdy_headers_frame_length = spdy_frame.size();
}
if (offset != nullptr) {
QuicStreamFrame frame(
kHeadersStreamId, false, *offset,
- base::StringPiece(spdy_frame->data(), spdy_frame->size()));
- *offset += spdy_frame->size();
+ base::StringPiece(spdy_frame.data(), spdy_frame.size()));
+ *offset += spdy_frame.size();
return MakePacket(header_, QuicFrame(&frame));
} else {
QuicStreamFrame frame(
kHeadersStreamId, false, 0,
- base::StringPiece(spdy_frame->data(), spdy_frame->size()));
+ base::StringPiece(spdy_frame.data(), spdy_frame.size()));
return MakePacket(header_, QuicFrame(&frame));
}
@@ -401,31 +401,31 @@ scoped_ptr<QuicReceivedPacket> QuicTestPacketMaker::MakeResponseHeadersPacket(
size_t* spdy_headers_frame_length,
QuicStreamOffset* offset) {
InitializeHeader(packet_number, should_include_version);
- scoped_ptr<SpdySerializedFrame> spdy_frame;
+ SpdySerializedFrame spdy_frame;
if (spdy_response_framer_.protocol_version() == SPDY3) {
SpdySynReplyIR syn_reply(stream_id);
syn_reply.set_header_block(headers);
syn_reply.set_fin(fin);
- spdy_frame.reset(spdy_response_framer_.SerializeSynReply(syn_reply));
+ spdy_frame = spdy_response_framer_.SerializeSynReply(syn_reply);
} else {
SpdyHeadersIR headers_frame(stream_id);
headers_frame.set_header_block(headers);
headers_frame.set_fin(fin);
- spdy_frame.reset(spdy_response_framer_.SerializeFrame(headers_frame));
+ spdy_frame = spdy_response_framer_.SerializeFrame(headers_frame);
}
if (spdy_headers_frame_length) {
- *spdy_headers_frame_length = spdy_frame->size();
+ *spdy_headers_frame_length = spdy_frame.size();
}
if (offset != nullptr) {
QuicStreamFrame frame(
kHeadersStreamId, false, *offset,
- base::StringPiece(spdy_frame->data(), spdy_frame->size()));
- *offset += spdy_frame->size();
+ base::StringPiece(spdy_frame.data(), spdy_frame.size()));
+ *offset += spdy_frame.size();
return MakePacket(header_, QuicFrame(&frame));
} else {
QuicStreamFrame frame(
kHeadersStreamId, false, 0,
- base::StringPiece(spdy_frame->data(), spdy_frame->size()));
+ base::StringPiece(spdy_frame.data(), spdy_frame.size()));
return MakePacket(header_, QuicFrame(&frame));
}
}
« no previous file with comments | « net/quic/spdy_utils.cc ('k') | net/spdy/buffered_spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698