Convert //url to use std::unique_ptr

Convert //url to use std::unique_ptr

BUG=554298
Committed: https://crrev.com/ea64f7caeafef5b77b656d03b4b8c4ec8edab4c0
Cr-Commit-Position: refs/heads/master@{#384831}

[Mostyn Bramley-Moore, 2016-04-01 20:14:50]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:15:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/1

[commit-bot: I haz the power, 2016-04-01 20:21:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 20:21:21]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mostyn Bramley-Moore, 2016-04-01 20:25:48]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:26:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/20001

[commit-bot: I haz the power, 2016-04-01 20:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 20:37:14]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Mostyn Bramley-Moore, 2016-04-01 20:51:10]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:51:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/40001

[commit-bot: I haz the power, 2016-04-01 21:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:15:34]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Mostyn Bramley-Moore, 2016-04-01 21:42:22]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 21:43:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/60001

[commit-bot: I haz the power, 2016-04-01 22:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 22:16:11]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mostyn Bramley-Moore, 2016-04-01 22:17:03]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 22:17:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/80001

[commit-bot: I haz the power, 2016-04-01 22:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 22:58:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mostyn Bramley-Moore, 2016-04-02 08:37:53]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 08:38:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/100001

[commit-bot: I haz the power, 2016-04-02 08:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 08:49:42]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Mostyn Bramley-Moore, 2016-04-02 08:54:30]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 08:54:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/120001

[commit-bot: I haz the power, 2016-04-02 09:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 09:12:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Mostyn Bramley-Moore, 2016-04-02 09:20:24]

@dcheng: lots of IWYU fixups required here too.  Would you prefer to include
base/memory/scoped_ptr.h in the offenders, or just switch them to
std::unique_ptr while I'm at it?

[dcheng, 2016-04-02 09:27:03]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-04-02 09:27:04]

I've been using this as an opportunity to reduce IWYU violations, e.g.:
- https://codereview.chromium.org/1852953002
- https://codereview.chromium.org/1847373005
- https://codereview.chromium.org/1846723007

That being said, I think it's also fine to try to find leaf dependencies and
start from those instead to avoid the problem. The reason is I don't see it
mattering much in the long-term: without any enforcement, this is inevitably
going to creep back into the codebase.

P.S. I've updated my scripts a bit, and
https://codereview.chromium.org/1505823003 also has a script which can help with
IWYU a bit that you can run ilke this:
python cheddar_monkey.py --header '"base/memory/scoped_ptr.h"' --build-dir
out_cros/Release -- -j 250 gn_all

If you look at the script, it's super dumb: it assumes any compile error it sees
is from a missing header and will just blindly throw the header into that file.
So you need to start from a build that was originally working and the only new
compile errors are a missing #include.

[Mostyn Bramley-Moore, 2016-04-02 09:33:10]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 09:33:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/140001

[commit-bot: I haz the power, 2016-04-02 10:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 10:48:19]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2016-04-02 10:57:06]

Description was changed from

==========
Convert //url to use std::unique_ptr

BUG=554298
==========

to

==========
Convert //url to use std::unique_ptr

BUG=554298
==========

[Mostyn Bramley-Moore, 2016-04-02 10:57:06]

mostynb@opera.com changed reviewers:
+ brettw@chromium.org

[Mostyn Bramley-Moore, 2016-04-02 10:58:01]

@brettw: since this sprawls across many directories, can you give this top-level
OWNER approval?

[brettw, 2016-04-02 20:35:08]

lgtm

[Mostyn Bramley-Moore, 2016-04-03 14:38:58]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-04-03 14:39:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851933002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851933002/140001

[commit-bot: I haz the power, 2016-04-03 16:03:54]

Description was changed from

==========
Convert //url to use std::unique_ptr

BUG=554298
==========

to

==========
Convert //url to use std::unique_ptr

BUG=554298
==========

[commit-bot: I haz the power, 2016-04-03 16:03:56]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-03 16:05:25]

Description was changed from

==========
Convert //url to use std::unique_ptr

BUG=554298
==========

to

==========
Convert //url to use std::unique_ptr

BUG=554298

Committed: https://crrev.com/ea64f7caeafef5b77b656d03b4b8c4ec8edab4c0
Cr-Commit-Position: refs/heads/master@{#384831}
==========

[commit-bot: I haz the power, 2016-04-03 16:05:27]

Patchset 8 (id:??) landed as
https://crrev.com/ea64f7caeafef5b77b656d03b4b8c4ec8edab4c0
Cr-Commit-Position: refs/heads/master@{#384831}