Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1851933002: Convert //url to use std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
brettw, dcheng
CC:
dcheng, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-manifest_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, Peter Beverloo, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //url to use std::unique_ptr BUG=554298 Committed: https://crrev.com/ea64f7caeafef5b77b656d03b4b8c4ec8edab4c0 Cr-Commit-Position: refs/heads/master@{#384831}

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : fixup 2 #

Patch Set 4 : fixup 3 #

Patch Set 5 : fixup 4 #

Patch Set 6 : fixup 5 #

Patch Set 7 : fixup 6 #

Patch Set 8 : IWYU fixup 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -106 lines) Patch
M chrome/browser/interstitials/security_interstitial_page.h View 1 2 3 4 5 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/interstitials/security_interstitial_page.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_driver.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M components/domain_reliability/uploader.h View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M components/domain_reliability/uploader.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippet.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippet.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/core/common/credential_manager_types.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/notifications/notification_database_data_conversions.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/request_info.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/service_worker/service_worker_provider_context.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.cc View 9 chunks +26 lines, -26 lines 0 comments Download
M content/child/webblobregistry_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/child/webblobregistry_impl.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M content/public/browser/navigation_controller.h View 4 chunks +7 lines, -5 lines 0 comments Download
M content/renderer/manifest/manifest_parser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/manifest/manifest_parser_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 2 3 4 5 6 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/test_info_extractor.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/test_info_extractor.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M device/usb/webusb_descriptors.h View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/renderer/dom_activity_logger.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 1 2 3 4 5 6 chunks +13 lines, -15 lines 0 comments Download
M net/cert/ct_log_verifier_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M net/http/http_auth_preferences.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_stream_sequencer_buffer_test.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M url/gurl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M url/run_all_unittests.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 45 (22 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/1
4 years, 8 months ago (2016-04-01 20:15:31 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/12685) ios_rel_device_ninja on ...
4 years, 8 months ago (2016-04-01 20:21:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/20001
4 years, 8 months ago (2016-04-01 20:26:21 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/153097)
4 years, 8 months ago (2016-04-01 20:37:14 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/40001
4 years, 8 months ago (2016-04-01 20:51:39 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/153123)
4 years, 8 months ago (2016-04-01 21:15:34 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/60001
4 years, 8 months ago (2016-04-01 21:43:07 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/194728)
4 years, 8 months ago (2016-04-01 22:16:11 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/80001
4 years, 8 months ago (2016-04-01 22:17:58 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/148247)
4 years, 8 months ago (2016-04-01 22:58:01 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/100001
4 years, 8 months ago (2016-04-02 08:38:03 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/44266)
4 years, 8 months ago (2016-04-02 08:49:42 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/120001
4 years, 8 months ago (2016-04-02 08:54:35 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/44372)
4 years, 8 months ago (2016-04-02 09:12:40 UTC) #28
Mostyn Bramley-Moore
@dcheng: lots of IWYU fixups required here too. Would you prefer to include base/memory/scoped_ptr.h in ...
4 years, 8 months ago (2016-04-02 09:20:24 UTC) #29
dcheng
I've been using this as an opportunity to reduce IWYU violations, e.g.: - https://codereview.chromium.org/1852953002 - ...
4 years, 8 months ago (2016-04-02 09:27:04 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/140001
4 years, 8 months ago (2016-04-02 09:33:17 UTC) #33
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 10:48:19 UTC) #35
Mostyn Bramley-Moore
@brettw: since this sprawls across many directories, can you give this top-level OWNER approval?
4 years, 8 months ago (2016-04-02 10:58:01 UTC) #38
brettw
lgtm
4 years, 8 months ago (2016-04-02 20:35:08 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851933002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851933002/140001
4 years, 8 months ago (2016-04-03 14:39:08 UTC) #41
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 8 months ago (2016-04-03 16:03:56 UTC) #43
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 16:05:27 UTC) #45
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/ea64f7caeafef5b77b656d03b4b8c4ec8edab4c0
Cr-Commit-Position: refs/heads/master@{#384831}

Powered by Google App Engine
This is Rietveld 408576698