Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1847373005: Fix IWYU violators that don't include scoped_ptr.h in Android build. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
aboxhall+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, jam, jbudorick+watch_chromium.org, je_julie, mcasas+watch_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nektar+watch_chromium.org, ortuno+watch_chromium.org, posciak+watch_chromium.org, scheib+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IWYU violators that don't include scoped_ptr.h in Android build. This blocks the conversion of //base from scoped_ptr to std::unique_ptr. BUG=554298 R=avi@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/af7ea1d22dca21a645f58d3c649aa9fd2b2d4e04 Cr-Commit-Position: refs/heads/master@{#384813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/android/accessibility/font_size_prefs_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/decoration_title.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_tab_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/content_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/child_process_launcher_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/media_drm_bridge_cdm_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/provision_fetcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
avi, mind reviewing this simple IWYU fix CL? I'll TBR brettw@ for global approval.
4 years, 8 months ago (2016-04-02 18:16:13 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-02 18:28:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847373005/1
4 years, 8 months ago (2016-04-02 18:31:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 18:35:54 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af7ea1d22dca21a645f58d3c649aa9fd2b2d4e04 Cr-Commit-Position: refs/heads/master@{#384813}
4 years, 8 months ago (2016-04-02 18:37:02 UTC) #9
brettw
4 years, 8 months ago (2016-04-02 20:37:13 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698