Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1852953002: Fix a bunch of IWYU violators that don't include scoped_ptr.h (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
danakj, brettw
CC:
Aaron Boodman, abarth-chromium, anandc+watch-blimp_chromium.org, asvitkine+watch_chromium.org, avayvod+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, cc-bugs_chromium.org, certificate-transparency-chrome_googlegroups.com, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dbeam+watch-settings_chromium.org, devtools-reviews_chromium.org, dtrainor+watch-blimp_chromium.org, eme-reviews_chromium.org, Eran Messeri, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gcasto+watchlist_chromium.org, groby+spellwatch_chromium.org, grt+watch_chromium.org, horo+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jbauman+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jessicag+watch-blimp_chromium.org, jochen+watch_chromium.org, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, jshin+watch_chromium.org, kalyank, kinuko+serviceworker, kinuko+watch, kinuko+fileapi, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, Matt Giuca, michaeln, michaelpg+watch-md-settings_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, Mostyn Bramley-Moore, nhiroki, noyau+watch_chromium.org, nyquist+watch-blimp_chromium.org, ortuno+watch_chromium.org, ozone-reviews_chromium.org, Peter Beverloo, pfeldman, piman+watch_chromium.org, plaree+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, rjkroege, rlp+watch_chromium.org, rouslan+autofill_chromium.org, rouslan+spell_chromium.org, sadrul, samuong+watch_chromium.org, scheduler-bugs_chromium.org, scheib+watch_chromium.org, serviceworker-reviews, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, stevenjb+watch-md-settings_chromium.org, tapted, tfarina, tim+watch_chromium.org, toyoshim+midi_chromium.org, tracing+reviews_chromium.org, tzik, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, wfh+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bunch of IWYU violators that don't include scoped_ptr.h This blocks the conversion of //base from scoped_ptr to std::unique_ptr. BUG=554298 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel R=danakj@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/556abd1195e93af420426e3e1f504343a77d20e9

Patch Set 1 #

Total comments: 4

Patch Set 2 : Restore newline #

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1 line) Patch
M ash/metrics/task_switch_metrics_recorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/app/blimp_discardable_memory_allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/net/blimp_message_multiplexer.h View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/net/connection_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/debug/devtools_instrumentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/debug/rendering_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/debug/traced_display_item_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/texture_mailbox_deleter.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/delay_based_time_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/ordered_simple_task_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_file_system_indexer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_file_watcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/feedback/system_logs/system_logs_fetcher_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/image_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox_profile_lock_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc_rtp_dump_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/webrtc_rtp_dump_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/pwg_raster_converter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_app_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_action_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_management/sampling/task_group_sampler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_prefs.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/profile_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/search_engines_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/auto_start_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/component_flash_hint_file_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/variations/variations_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome/log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/image_writer/image_writer_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/cloud_devices/common/cloud_device_description.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/db_data_owner.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/favicon/core/favicon_driver_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_delayed_task_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/guest_view/renderer/guest_view_request.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/keyed_service/content/browser_context_dependency_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/keyed_service/core/keyed_service_shutdown_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/profiler/tracking_synchronizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/browser/pnacl_translation_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/facet_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_consumer.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/cryptauth/sync_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/base/task_queue_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/base/task_queue_manager_delegate_for_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/child/scheduler_tqm_delegate_for_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/child/scheduler_tqm_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/child/worker_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/renderer/task_cost_estimator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/search/search_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/account_id/account_id.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/local_device_info_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/tracing/trace_config_file.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/visitedlink/browser/visitedlink_master.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/webcrypto/jwk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_process_sub_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_frame_trace_recorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/fileapi/native_file_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/window_activity_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/notifications/notification_database.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_database_task_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/zygote_host/zygote_communication_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/resource_scheduling_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/font_config_ipc_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/background_tracing_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/background_tracing_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/download_save_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_web_contents_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/in_process_renderer_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/audio_repetition_detector_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_recorder_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_track_recorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_chooser_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/utility/in_process_utility_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/exported_object.h View 1 chunk +1 line, -0 lines 0 comments Download
M dbus/object_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/declarative/deduping_factory_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/declarative/rules_cache_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_pref_value_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/event_bindings.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/drive/task_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/connection_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/native/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_pull_fifo.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/bind_to_current_loop.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/demuxer.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/yuv_convert_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/net/cast_transport_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/decoder_selector.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/usb_midi_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/muxers/webm_muxer.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/catalog/store.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/public/cpp/initialize_base_and_icu.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/file_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_change_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/client_cert_verifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/crl_set_storage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/ct_log_response_parser_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/ssl/threaded_ssl_private_key.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/interface_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/clipboard.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/linux/audio_pipe_reader_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/native_messaging/log_message_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/authenticator_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/chromium_socket_factory_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/webrtc_video_renderer_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/signaling/xmpp_stream_parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/fake_socket_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/skia_memory_dump_provider_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sync/api/model_type_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/attachments/task_queue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/web_process_memory_dump_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/leveldatabase/chromium_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/exec_process.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/draw_waiter_for_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gpu_switching_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/animation/bounds_animator.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dcheng
https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (left): https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc#oldcode6 chrome/common/logging_chrome.cc:6: I'll restore this newline, just noticed the script ate ...
4 years, 8 months ago (2016-04-02 00:36:26 UTC) #4
dcheng
https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (left): https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc#oldcode6 chrome/common/logging_chrome.cc:6: On 2016/04/02 at 00:36:26, dcheng wrote: > I'll restore ...
4 years, 8 months ago (2016-04-02 00:54:06 UTC) #5
danakj
LGTM https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (right): https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc#newcode5 chrome/common/logging_chrome.cc:5: #include "base/memory/scoped_ptr.h" The header should go down with ...
4 years, 8 months ago (2016-04-02 01:02:16 UTC) #6
dcheng
https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (right): https://codereview.chromium.org/1852953002/diff/1/chrome/common/logging_chrome.cc#newcode5 chrome/common/logging_chrome.cc:5: #include "base/memory/scoped_ptr.h" On 2016/04/02 at 01:02:16, danakj wrote: > ...
4 years, 8 months ago (2016-04-02 01:11:44 UTC) #7
dcheng
TBRing brettw (this is just adding a line to include scoped_ptr.h for files that use ...
4 years, 8 months ago (2016-04-02 01:15:12 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/556abd1195e93af420426e3e1f504343a77d20e9 Cr-Commit-Position: refs/heads/master@{#384767}
4 years, 8 months ago (2016-04-02 01:15:38 UTC) #11
dcheng
Committed patchset #3 (id:40001) manually as 556abd1195e93af420426e3e1f504343a77d20e9.
4 years, 8 months ago (2016-04-02 01:16:24 UTC) #13
brettw
4 years, 8 months ago (2016-04-02 20:36:37 UTC) #14
Message was sent while issue was closed.
rs lgtm (spot checked)

Powered by Google App Engine
This is Rietveld 408576698