Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846723007: Fix IWYU violators that don't include scoped_ptr.h in CrOS build. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
achuith+watch_chromium.org, chirantan+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, kalyank, kinuko+fileapi, nhiroki, oshima+watch_chromium.org, sadrul, tfarina, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IWYU violators that don't include scoped_ptr.h in CrOS build. This blocks the conversion of //base from scoped_ptr to std::unique_ptr. BUG=554298 R=avi@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/ddbd4743af3f854041d9fe270d4e5226bceb214d Cr-Commit-Position: refs/heads/master@{#384812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/chromeos/certificate_provider/certificate_requests.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/async_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/server_backed_state_keys_broker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/demo_mode_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/app_mode/kiosk_oem_manifest_parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/fake_easy_unlock_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/disks/mock_disk_mount_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/process_proxy/process_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/tpm/tpm_token_info_getter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/tpm/tpm_token_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/timers/alarm_timer_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
avi, mind reviewing this simple IWYU fix CL? I'll TBR brettw@ for global approval.
4 years, 8 months ago (2016-04-02 18:16:10 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-02 18:18:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846723007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846723007/1
4 years, 8 months ago (2016-04-02 18:27:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 18:32:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ddbd4743af3f854041d9fe270d4e5226bceb214d Cr-Commit-Position: refs/heads/master@{#384812}
4 years, 8 months ago (2016-04-02 18:33:41 UTC) #9
brettw
4 years, 8 months ago (2016-04-02 20:37:41 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698