Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1851293005: Improve CPU Profile View (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve CPU Profile View Service: - [x] Add "_profilerMode" to VM response. "VM" or "Dart" depending on --profile-vm flag. - [x] Output a tree where VM tag are treated as executing "exit frame" functions when profiling Dart. - [x] tick "exit frame" tag functions when profiling Dart. Observatory: - [x] don't include option for VM tags when profiling Dart. - [x] default to no tags when profiling Dart. - [x] indent the colored bar closer to the down arrow. - [x] don't show percentages for user tag rows. - [x] Update cpu profile table view to use virtual tree. - [x] Update class allocation view to use virtual tree. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b895aa51548bc7f979af1261bac1c90ec1b71ac8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -82 lines) Patch
M runtime/observatory/lib/src/app/view_model.dart View 5 chunks +9 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 8 chunks +104 lines, -27 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 3 chunks +25 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/get_allocation_samples_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 1 10 chunks +147 lines, -38 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 2 33 chunks +74 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/tags.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/tags.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 8 months ago (2016-04-04 14:09:10 UTC) #3
rmacnak
lgtm
4 years, 8 months ago (2016-04-04 18:07:05 UTC) #4
Cutch
4 years, 7 months ago (2016-05-13 17:07:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b895aa51548bc7f979af1261bac1c90ec1b71ac8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698