runtime/observatory/tests/service/get_allocation_samples_test.dart - Issue 1851293005: Improve CPU Profile View

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_allocation_samples_test.dart

Issue 1851293005: Improve CPU Profile View (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/get_allocation_samples_test.dart

diff --git a/runtime/observatory/tests/service/get_allocation_samples_test.dart b/runtime/observatory/tests/service/get_allocation_samples_test.dart

index 87615c9f3cd207ff7a9229bbc014deb7b118f1a5..85626ee47a9c8383ef1558c22d2e4d47b383263f 100644

--- a/runtime/observatory/tests/service/get_allocation_samples_test.dart

+++ b/runtime/observatory/tests/service/get_allocation_samples_test.dart

@@ -67,7 +67,7 @@ var tests = [

var tree = cpuProfile.loadCodeTree('exclusive');

var node = tree.root;

var expected =

- ['Root', 'test', 'test', '_Closure.call'];

+ ['Root', 'DRT_AllocateObject', 'test', 'test', '_Closure.call'];

for (var i = 0; i < expected.length; i++) {

expect(node.profileCode.code.name, equals(expected[i]));

// Depth first traversal.

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/profiler_service.cc » ('j') | no next file with comments »