Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: runtime/observatory/lib/src/app/view_model.dart

Issue 1851293005: Improve CPU Profile View (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/class_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/view_model.dart
diff --git a/runtime/observatory/lib/src/app/view_model.dart b/runtime/observatory/lib/src/app/view_model.dart
index 6562e1f1f6da783ac57208f9cbc6afa5a4dede3c..76033ebbdd4611c391ecb36fb63a15d7e6e94bb7 100644
--- a/runtime/observatory/lib/src/app/view_model.dart
+++ b/runtime/observatory/lib/src/app/view_model.dart
@@ -6,7 +6,7 @@ part of app;
abstract class VirtualTreeRow {
// Number of ems each subtree is indented.
- static const subtreeIndent = 1.05;
+ static const subtreeIndent = 2.0;
static const redColor = '#F44336';
static const blueColor = '#3F51B5';
@@ -46,7 +46,7 @@ abstract class VirtualTreeRow {
}
}
- Element makeColorBar() {
+ Element makeColorBar(int depth) {
var element = new SpanElement();
element.style.paddingLeft = '2px';
element.style.paddingRight = '2px';
@@ -78,7 +78,7 @@ abstract class VirtualTreeRow {
return element;
}
- Element makeIndenter({colored: true}) {
+ Element makeIndenter(int depth, {colored: true}) {
SpanElement element = new SpanElement();
element.style.paddingLeft = '${subtreeIndent * depth}em';
element.style.flexBasis = '${subtreeIndent * depth}em';
@@ -93,7 +93,9 @@ abstract class VirtualTreeRow {
return element;
}
- Element makeText(String text, {String toolTip, String flexBasis: '7em'}) {
+ Element makeText(String text, {String toolTip,
+ String flexBasis: '4.5em',
+ String cssClass}) {
SpanElement element = new SpanElement();
element.text = text;
if (toolTip != null) {
@@ -102,6 +104,9 @@ abstract class VirtualTreeRow {
if (flexBasis != null) {
element.style.flexBasis = flexBasis;
}
+ if (cssClass != null) {
+ element.classes.add(cssClass);
+ }
return element;
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/class_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698