Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile.html

Issue 1851293005: Improve CPU Profile View (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile.html
diff --git a/runtime/observatory/lib/src/elements/cpu_profile.html b/runtime/observatory/lib/src/elements/cpu_profile.html
index b5f2432d3dc97fc59c045d02c2de2a1e04753ca9..50db2dbafab2a091d010c388c786d66064e08bb7 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile.html
+++ b/runtime/observatory/lib/src/elements/cpu_profile.html
@@ -91,13 +91,21 @@
<div class="memberItem">
<div class="memberName">Tag Order</div>
<div class="memberValue">
- <select value="{{tagSelector}}">
- <option value="UserVM">User &gt; VM</option>
- <option value="UserOnly">User</option>
- <option value="VMUser">VM &gt; User</option>
- <option value="VMOnly">VM</option>
- <option value="None">None</option>
- </select>
+ <template if="{{ profileVM }}">
+ <select value="{{tagSelector}}">
+ <option value="UserVM">User &gt; VM</option>
+ <option value="UserOnly">User</option>
+ <option value="VMUser">VM &gt; User</option>
+ <option value="VMOnly">VM</option>
+ <option value="None">None</option>
+ </select>
+ </template>
+ <template if="{{ !profileVM }}">
+ <select value="{{tagSelector}}">
+ <option value="UserOnly">User</option>
+ <option value="None">None</option>
+ </select>
+ </template>
</div>
</div>
</template>
@@ -254,6 +262,15 @@
height: 50%;
width: 100%;
}
+ .coldProfile {
+ background-color: #aea;
+ }
+ .mediumProfile {
+ background-color: #fe9;
+ }
+ .hotProfile {
+ background-color: #faa;
+ }
</style>
<div id="tree" class="full"></div>
</template>
@@ -468,7 +485,7 @@
<br>
<div class="flex-row centered">
<div class="flex-item-90-percent outlined" style="margin: 16px; margin-left: 8px; margin-right: 8px">
- <cpu-profile-tree id="cpuProfileTree"></cpu-profile-tree>
+ <cpu-profile-virtual-tree id="cpuProfileTree"></cpu-profile-virtual-tree>
</div>
</div>
</template>
« no previous file with comments | « runtime/observatory/lib/src/elements/cpu_profile.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698