third_party/WebKit/public/platform/WebMemoryAllocatorDump.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

diff --git a/third_party/WebKit/public/platform/WebMemoryAllocatorDump.h b/third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

index 6d1fefe8aaf79bbc26267a56619a4d5ce5e103de..8142725ae70950761f60bc443d71811f393c0097 100644

--- a/third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

+++ b/third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

@@ -35,11 +35,7 @@ public:

// cross process sharing. See crbug.com/492102 for design docs.

// Subsequent MemoryAllocatorDump(s) with the same |absolute_name| are

// expected to have the same guid.

- virtual WebMemoryAllocatorDumpGuid guid() const

- {

- BLINK_ASSERT_NOT_REACHED();

- return 0;

- }

+ virtual WebMemoryAllocatorDumpGuid guid() const = 0;

};

} // namespace blink

« no previous file with comments | « third_party/WebKit/public/platform/WebFileSystem.h ('k') | third_party/WebKit/public/platform/WebPrivateOwnPtr.h » ('j') | no next file with comments »