Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/public/platform/WebFileSystem.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebFileSystem.h
diff --git a/third_party/WebKit/public/platform/WebFileSystem.h b/third_party/WebKit/public/platform/WebFileSystem.h
index 7311ddc600f499649df23df0420fb71e130996df..9c363d9cd29e06efac09de0c315cbfa386eba51e 100644
--- a/third_party/WebKit/public/platform/WebFileSystem.h
+++ b/third_party/WebKit/public/platform/WebFileSystem.h
@@ -59,14 +59,14 @@ public:
// a name and root path for the requested FileSystem when the operation
// is completed successfully. WebFileSystemCallbacks::didFail() must be
// called otherwise.
- virtual void openFileSystem(const WebURL& storagePartition, const WebFileSystemType, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void openFileSystem(const WebURL& storagePartition, const WebFileSystemType, WebFileSystemCallbacks) = 0;
// Resolves a filesystem URL.
// WebFileSystemCallbacks::didSucceed() must be called with filesystem
// information (name, root path and type) and file metadata (file path and
// file type) when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void resolveURL(const WebURL& fileSystemURL, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void resolveURL(const WebURL& fileSystemURL, WebFileSystemCallbacks) = 0;
// Deletes FileSystem.
// WebFileSystemCallbacks::didSucceed() must be called when the operation
@@ -79,29 +79,29 @@ public:
// Moves a file or directory at |srcPath| to |destPath|.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void move(const WebURL& srcPath, const WebURL& destPath, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void move(const WebURL& srcPath, const WebURL& destPath, WebFileSystemCallbacks) = 0;
// Copies a file or directory at |srcPath| to |destPath|.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void copy(const WebURL& srcPath, const WebURL& destPath, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void copy(const WebURL& srcPath, const WebURL& destPath, WebFileSystemCallbacks) = 0;
// Deletes a file or directory at a given |path|.
// It is an error to try to remove a directory that is not empty.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void remove(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void remove(const WebURL& path, WebFileSystemCallbacks) = 0;
// Deletes a file or directory recursively at a given |path|.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void removeRecursively(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void removeRecursively(const WebURL& path, WebFileSystemCallbacks) = 0;
// Retrieves the metadata information of the file or directory at the given |path|.
// This may not always return the local platform path in remote filesystem cases.
// WebFileSystemCallbacks::didReadMetadata() must be called with a valid metadata when the retrieval is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void readMetadata(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void readMetadata(const WebURL& path, WebFileSystemCallbacks) = 0;
// Creates a file at given |path|.
// If the |path| doesn't exist, it creates a new file at |path|.
@@ -111,7 +111,7 @@ public:
//
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void createFile(const WebURL& path, bool exclusive, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void createFile(const WebURL& path, bool exclusive, WebFileSystemCallbacks) = 0;
// Creates a directory at a given |path|.
// If the |path| doesn't exist, it creates a new directory at |path|.
@@ -121,27 +121,27 @@ public:
// WebFileSystemCallbacks::didSucceed() must be called when
// the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void createDirectory(const WebURL& path, bool exclusive, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void createDirectory(const WebURL& path, bool exclusive, WebFileSystemCallbacks) = 0;
// Checks if a file exists at a given |path|.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void fileExists(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void fileExists(const WebURL& path, WebFileSystemCallbacks) = 0;
// Checks if a directory exists at a given |path|.
// WebFileSystemCallbacks::didSucceed() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void directoryExists(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void directoryExists(const WebURL& path, WebFileSystemCallbacks) = 0;
// Reads directory entries of a given directory at |path| and returns a callbacks ID which can be used to wait for additional results.
// WebFileSystemCallbacks::didReadDirectory() must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual int readDirectory(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); return 0; }
+ virtual int readDirectory(const WebURL& path, WebFileSystemCallbacks) = 0;
// Creates a WebFileWriter that can be used to write to the given file.
// WebFileSystemCallbacks::didCreateFileWriter() must be called with the created WebFileWriter when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void createFileWriter(const WebURL& path, WebFileWriterClient*, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void createFileWriter(const WebURL& path, WebFileWriterClient*, WebFileSystemCallbacks) = 0;
// Creates a snapshot file for a given file specified by |path|. It returns the metadata of the created snapshot file.
// The returned metadata should include a local platform path to the snapshot image.
@@ -151,12 +151,12 @@ public:
// The snapshot file is supposed to be deleted when the last reference to a blink::File referring to it's path is dropped.
// WebFileSystemCallbacks::didCreateSnapshotFile() with the metadata of the snapshot file must be called when the operation is completed successfully.
// WebFileSystemCallbacks::didFail() must be called otherwise.
- virtual void createSnapshotFileAndReadMetadata(const WebURL& path, WebFileSystemCallbacks) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void createSnapshotFileAndReadMetadata(const WebURL& path, WebFileSystemCallbacks) = 0;
// Waits for additional results returned for the method call and returns true if possible.
// Returns false if there is no running method call corresponding for the given ID.
// |callbacksId| must be the value returned by the original method call.
- virtual bool waitForAdditionalResult(int callbacksId) { BLINK_ASSERT_NOT_REACHED(); return false; }
+ virtual bool waitForAdditionalResult(int callbacksId) = 0;
protected:
virtual ~WebFileSystem() { }

Powered by Google App Engine
This is Rietveld 408576698