Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Side by Side Diff: third_party/WebKit/public/platform/WebMemoryAllocatorDump.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebMemoryAllocatorDump_h 5 #ifndef WebMemoryAllocatorDump_h
6 #define WebMemoryAllocatorDump_h 6 #define WebMemoryAllocatorDump_h
7 7
8 #include "WebCommon.h" 8 #include "WebCommon.h"
9 #include "WebString.h" 9 #include "WebString.h"
10 10
(...skipping 17 matching lines...) Expand all
28 virtual void addScalar(const char* name, const char* units, uint64_t value) {} 28 virtual void addScalar(const char* name, const char* units, uint64_t value) {}
29 virtual void addScalarF(const char* name, const char* units, double value) { } 29 virtual void addScalarF(const char* name, const char* units, double value) { }
30 virtual void addString(const char* name, const char* units, const WebString& value) {} 30 virtual void addString(const char* name, const char* units, const WebString& value) {}
31 31
32 // |guid| is an optional global dump identifier, unique across all processes 32 // |guid| is an optional global dump identifier, unique across all processes
33 // within the scope of a global dump. It is only required when using the 33 // within the scope of a global dump. It is only required when using the
34 // graph APIs (see AddOwnershipEdge) to express retention / suballocation or 34 // graph APIs (see AddOwnershipEdge) to express retention / suballocation or
35 // cross process sharing. See crbug.com/492102 for design docs. 35 // cross process sharing. See crbug.com/492102 for design docs.
36 // Subsequent MemoryAllocatorDump(s) with the same |absolute_name| are 36 // Subsequent MemoryAllocatorDump(s) with the same |absolute_name| are
37 // expected to have the same guid. 37 // expected to have the same guid.
38 virtual WebMemoryAllocatorDumpGuid guid() const 38 virtual WebMemoryAllocatorDumpGuid guid() const = 0;
39 {
40 BLINK_ASSERT_NOT_REACHED();
41 return 0;
42 }
43 }; 39 };
44 40
45 } // namespace blink 41 } // namespace blink
46 42
47 #endif // WebMemoryAllocatorDump_h 43 #endif // WebMemoryAllocatorDump_h
OLDNEW
« no previous file with comments | « third_party/WebKit/public/platform/WebFileSystem.h ('k') | third_party/WebKit/public/platform/WebPrivateOwnPtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698