Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/public/platform/WebPrivateOwnPtr.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebPrivateOwnPtr.h
diff --git a/third_party/WebKit/public/platform/WebPrivateOwnPtr.h b/third_party/WebKit/public/platform/WebPrivateOwnPtr.h
index 30a5cb273cf8fc2929b2fb7e16bab1a1c1c906a0..060a6217fdc24b98880347f175e70d81f3aaad0e 100644
--- a/third_party/WebKit/public/platform/WebPrivateOwnPtr.h
+++ b/third_party/WebKit/public/platform/WebPrivateOwnPtr.h
@@ -29,6 +29,7 @@
#include "WebCommon.h"
#include "WebNonCopyable.h"
+#include "base/logging.h"
#include <cstddef>
#if INSIDE_BLINK
@@ -48,7 +49,7 @@ class WebPrivateOwnPtr : public WebNonCopyable {
public:
WebPrivateOwnPtr() : m_ptr(nullptr) {}
WebPrivateOwnPtr(std::nullptr_t) : m_ptr(nullptr) {}
- ~WebPrivateOwnPtr() { BLINK_ASSERT(!m_ptr); }
+ ~WebPrivateOwnPtr() { DCHECK(!m_ptr); }
explicit WebPrivateOwnPtr(T* ptr)
: m_ptr(ptr)
@@ -80,13 +81,13 @@ public:
T& operator*() const
{
- BLINK_ASSERT(m_ptr);
+ DCHECK(m_ptr);
return *m_ptr;
}
T* operator->() const
{
- BLINK_ASSERT(m_ptr);
+ DCHECK(m_ptr);
return m_ptr;
}
#endif // INSIDE_BLINK
« no previous file with comments | « third_party/WebKit/public/platform/WebMemoryAllocatorDump.h ('k') | third_party/WebKit/public/platform/WebPrivatePtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698