Remove unused ash::SHELF_ALIGNMENT_TOP

Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests

Committed: https://crrev.com/41fa68e9c867762958afec17e68508a4697de1a4
Cr-Commit-Position: refs/heads/master@{#384933}

[James Cook, 2016-03-30 23:03:14]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 23:03:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849623002/1

[James Cook, 2016-03-30 23:22:09]

Description was changed from

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead, and top-alignment code has been cargo-culted around
as new features are added.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests
==========

to

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests
==========

[James Cook, 2016-03-30 23:22:22]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 23:22:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849623002/20001

[James Cook, 2016-03-30 23:23:18]

jamescook@chromium.org changed reviewers:
+ oshima@chromium.org

[James Cook, 2016-03-30 23:23:19]

oshima, PTAL

msw, no need to review, just FYI for the mustash shelf work

[commit-bot: I haz the power, 2016-03-30 23:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:47:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[oshima, 2016-03-30 23:59:57]

lgtm

https://codereview.chromium.org/1849623002/diff/20001/ash/system/web_notifica...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/system/web_notifica...
ash/system/web_notification/web_notification_tray.cc:237: NOTREACHED();
can you remove the default while we're at it?

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/app_list_control...
File ash/wm/app_list_controller.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/app_list_control...
ash/wm/app_list_controller.cc:110: return gfx::Vector2d();
ditto. and move return to the end.

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/panels/attached_...
File ash/wm/panels/attached_panel_window_targeter.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/panels/attached_...
ash/wm/panels/attached_panel_window_targeter.cc:66: return;
ditto

[James Cook, 2016-04-04 15:56:05]

Thanks for the review.

https://codereview.chromium.org/1849623002/diff/20001/ash/system/web_notifica...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/system/web_notifica...
ash/system/web_notification/web_notification_tray.cc:237: NOTREACHED();
On 2016/03/30 23:59:57, oshima wrote:
> can you remove the default while we're at it?

Done.

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/app_list_control...
File ash/wm/app_list_controller.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/app_list_control...
ash/wm/app_list_controller.cc:110: return gfx::Vector2d();
On 2016/03/30 23:59:57, oshima wrote:
> ditto. and move return to the end.

Done.

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/panels/attached_...
File ash/wm/panels/attached_panel_window_targeter.cc (right):

https://codereview.chromium.org/1849623002/diff/20001/ash/wm/panels/attached_...
ash/wm/panels/attached_panel_window_targeter.cc:66: return;
On 2016/03/30 23:59:57, oshima wrote:
> ditto

Done.

[James Cook, 2016-04-04 16:29:46]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-04-04 16:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1849623002/#ps50042
(title: "rebase")

[commit-bot: I haz the power, 2016-04-04 16:30:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849623002/50042
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849623002/50042

[commit-bot: I haz the power, 2016-04-04 17:07:09]

Description was changed from

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests
==========

to

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests
==========

[commit-bot: I haz the power, 2016-04-04 17:07:11]

Committed patchset #4 (id:50042)

[commit-bot: I haz the power, 2016-04-04 17:08:35]

Description was changed from

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests
==========

to

==========
Remove unused ash::SHELF_ALIGNMENT_TOP

We never actually shipped the ability to place the shelf on the top of the
screen, in part due to UX issues around the tab strip and notifications. The
existing code is all dead and top-alignment code has been cargo-culted around
as new features are added.

If any accounts have an existing shelf alignment pref with the value "top"
their shelf will switch to bottom. This would only be test accounts created
several years ago -- no production accounts will have that alignment.

This will make mus/mustash work easier, as it won't have to support the extra
unused shelf alignment.

BUG=none
TEST=compiles, existing ash tests

Committed: https://crrev.com/41fa68e9c867762958afec17e68508a4697de1a4
Cr-Commit-Position: refs/heads/master@{#384933}
==========

[commit-bot: I haz the power, 2016-04-04 17:08:36]

Patchset 4 (id:??) landed as
https://crrev.com/41fa68e9c867762958afec17e68508a4697de1a4
Cr-Commit-Position: refs/heads/master@{#384933}